Adservio Code Review Analysis
A read-only analysis of recent merge request review behavior in GitLab, focused on visible review discussion, reviewer distribution, queue health, MR size, and traceability gaps.
Executive Summary
Bottom line: review throughput is not the main risk here; traceability and queue hygiene are. The team is still merging code, but most merges leave no durable visible review trail and the open queue is overwhelmingly stale.
What Matters
- Traceability is the clearest control gap: 27 of 37 merged MRs (73.0%) showed no visible non-author review comment in GitLab.
- `CR - Approved` is currently too weak as evidence on its own: 48.6% of merged MRs carried that label without any visible review discussion.
- Queue health is poor: 97.1% of active open MRs are already older than 48 working hours. The oldest example is adservio/web!2091 at 191.5d open.
- Visible review capacity is thin and concentrated: only 13 visible review touches were detected in the whole window, and the top 3 reviewers handled 61.5% of them.
- adservio/frontend is the highest-volume review surface with 14 merged MRs and only 35.7% visible review coverage. adservio/web is the next meaningful flow at 9 merges and 33.3% visible review coverage.
- MR size is not the main story: median changed files were 4, and only 8.1% of merged MRs were above 20 files. Even the slowest merged example, adservio/web!2417, took 16.1d with 4 changed files, so the dominant problem still looks like review discipline and queue ownership rather than consistently oversized MRs.
Leadership Analysis
- The operating rhythm is serviceable at the median (46.9h created-to-merged), which means the biggest leverage is improving process fidelity rather than pushing for even more raw throughput.
- With 97.1% of active MRs already stale, the open list is functioning more like inventory than prioritization support. adservio/web!2091 being open for 191.5d is a strong sign that ownership and review handoffs are not being actively reset.
- Reviewer concentration is now a resilience issue, not just a fairness issue. When the top 3 reviewers carry 61.5% of visible touches, review quality, continuity, and queue health all become sensitive to a very small set of people.
- The spread between a 4-file median MR and a 16.1d longest merged cycle (adservio/web!2417, 4 changed files) suggests a few ownership-heavy exceptions are dragging on outside normal flow. Those should be managed as explicit escalations, not left to age inside the common queue.
Recommended Actions
- Make one durable review artifact mandatory before merge: a substantive non-author GitLab review comment, a recorded approval, or both. A label alone should no longer count as sufficient evidence. The approval API coverage is also low, so the fix should include tooling or policy that leaves an auditable trace by default.
- Run a stale-MR reset on anything older than 48 working hours: close abandoned work, re-confirm owner and reviewer on the rest, and turn the open list back into a real queue instead of a parking lot. Start with adservio/web!2091 and the rest of the oldest backlog because their age now obscures whether they are still real priorities.
- Put adservio/uni/backend under explicit review guardrails for the next cycle. It combines enough volume with weak visible review coverage, which makes it the best place to tighten the process and see impact quickly.
- Broaden the reviewer bench beyond Daniel Onisoru and the current small reviewer set. The present concentration is a continuity risk and will keep queue health fragile when one person is away.
Improvement Ideas
- Set explicit operating standards for the next quarter: require one auditable peer-review artifact before merge, target first review inside one working day for active MRs, and keep the stale active backlog below 15%. What gets measured this clearly is far more likely to improve.
- Run a four-week process experiment on adservio/uni/backend: dedicated reviewer-of-the-week coverage, explicit reviewer assignment at MR creation, and a lightweight weekly audit of silent merges. It is the highest-yield place to test whether better ownership changes the data.
- Create a reviewer rotation with named backup coverage for the busiest repos. Good review systems depend on redundancy, not heroics, and rotation is the fastest way to lower reviewer bus factor without slowing delivery.
Supporting Evidence
- 27 of 37 merged MRs (73.0%) had no visible non-author review comment in GitLab.
- 27 of 37 merged MRs (73.0%) carried the `CR - Approved` label.
- 18 merged MRs (48.6%) were labeled `CR - Approved` without any visible non-author review comment.
- 8.1% of merged MRs changed more than 20 files, while 5.4% changed more than 50 files.
- Among MRs with visible review discussion, the median last-author-commit to first-review time was 23.6h.
- The median last-author-commit to `CR - Approved` time was 2.9d.
- The top 3 reviewers accounted for 61.5% of visible review touches.
- 34 of 35 active open MRs (97.1%) were older than 48 working hours.
Merged MRs Merged MRs inside the analysis window. | 37 |
Open MRs All currently open group MRs. | 41 |
Active open MRs Open MRs excluding drafts. | 35 |
Draft open MRs Open MRs marked draft/WIP. | 6 |
Visible review rate Merged MRs with at least one visible non-author GitLab comment. | 27.0% |
Merged without visible review comment Merged MRs with zero visible non-author comments. | 73.0% |
CR - Approved label coverage Merged MRs carrying the CR-approved label. | 73.0% |
Approval API coverage Merged MRs with at least one approver in the GitLab approvals API. | 13.5% |
CR - Approved without visible review comment CR-approved MRs with no visible non-author comment. | 48.6% |
Median MR created -> first review Working time from MR creation to first visible non-author comment. | 4.1d |
Median last author commit -> first review Working time from last author commit before review to first visible non-author comment. | 23.6h |
Median first review -> CR - Approved Working time from first visible comment to CR-approved label after review start, else merge. | 23.6h |
Median MR created -> CR - Approved Working time from MR creation to CR-approved label after review start, else merge. | 8.5d |
Median last author commit -> CR - Approved Working time from last author commit before review to CR-approved label after review start, else merge. | 2.9d |
Median MR created -> merged Working time from MR creation to merge. | 46.9h |
Median changed files Median GitLab `changes_count` value. | 4 |
MRs > 5 files Merged MRs where `changes_count` is above 5. | 40.5% |
MRs > 10 files Merged MRs where `changes_count` is above 10. | 18.9% |
MRs > 20 files Merged MRs where `changes_count` is above 20. | 8.1% |
MRs > 50 files Merged MRs where `changes_count` is above 50. | 5.4% |
Top 3 reviewer touch share Share of visible review touches handled by the top 3 reviewers. | 61.5% |
Active open backlog rate Non-draft open MRs older than 48 working hours. | 97.1% |
Timing Breakdown
These headline timing medians bring back the anchor-to-anchor numbers directly, using working time with weekends excluded.
| Median MR created -> first review | 4.1d |
| Median last author commit -> first review | 23.6h |
| Median MR created -> CR - Approved | 8.5d |
| Median first review -> CR - Approved | 23.6h |
| Median last author commit -> CR - Approved | 2.9d |
| Median MR created -> merged | 46.9h |
Reviewer Distribution
| Daniel Onisoru | 3 | 13 | 23.1% |
| Ioana Ivan | 3 | 12 | 23.1% |
| Andrei Dragan | 2 | 4 | 15.4% |
| Marian Andrei | 1 | 1 | 7.7% |
| Dragoș Ivan | 1 | 1 | 7.7% |
| Achim Stefan | 1 | 2 | 7.7% |
| Edgar Alexa | 1 | 3 | 7.7% |
| George Murgoci | 1 | 1 | 7.7% |
Repo Breakdown
| adservio/frontend | 14 | 35.7% | 85.7% | 4.0 |
| adservio/web | 9 | 33.3% | 33.3% | 2 |
| adservio/uni/backend | 5 | 0.0% | 100.0% | 3 |
| adservio/billing/backend | 2 | 0.0% | 50.0% | 4.5 |
| adservio/docgen2/backend | 2 | 0.0% | 100.0% | 2.0 |
| adservio/subscriptions/backend | 2 | 50.0% | 100.0% | 14.0 |
| adservio/admission/backend | 1 | 0.0% | 100.0% | 8 |
| adservio/helm2 | 1 | 0.0% | 0.0% | 13 |
| adservio/services/notifications | 1 | 100.0% | 100.0% | 102 |
Visible Review Discussion MRs
Compact by default: key CR metrics stay visible, and each row expands inline for the full audit trail. The table starts sorted by Last Commit -> First Review.
| Details | ||||||
|---|---|---|---|---|---|---|
| adservio/web!2441 | [ADS-7058] Adaugare checkbox pentru scoli pentru initiala tatalui | 3/5 Solid | 44.9h | 0.3h | 46.9h | |
Repo adservio/web Author Catalin Cojan Reviewers Marian Andrei Review Comments 1 Quality Notes 1 visible comment; 1 substantive comment; single reviewer; 2 post-review pushes Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 2 MR Created 2026-04-03 17:55 Last Author Commit 2026-04-07 14:31 First Review 2026-04-07 14:50 CR Approved n/a Merged 2026-04-07 16:50 First Review -> CR Approved 2.0h Last Commit -> CR Approved 2.3h Created -> Merged 46.9h | ||||||
| adservio/frontend!1721 | [ADS-7221]: add automated tests for homeworks | 3/5 Solid | 1.3h | 0.7h | 1.9h | |
Repo adservio/frontend Author Paul Tanasuca Reviewers Ioana Ivan Review Comments 2 Quality Notes 2 visible comments; 1 substantive comment; single reviewer; 1 post-review push Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 1 MR Created 2026-04-09 12:39 Last Author Commit 2026-04-09 13:11 First Review 2026-04-09 13:55 CR Approved 2026-04-09 14:34 Merged 2026-04-09 14:34 First Review -> CR Approved 0.7h Last Commit -> CR Approved 1.4h Created -> Merged 1.9h | ||||||
| adservio/frontend!1698 | [ADS-6434]: Marketing Notifications | 3/5 Solid | 5.3d | 2.2h | 5.2d | |
Repo adservio/frontend Author Dragoș Ivan Reviewers Ioana Ivan Review Comments 9 Quality Notes 9 visible comments; 5 substantive comments; single reviewer; multi-point discussion Substantive Comments 5 Reviewer Count 1 Post-Review Pushes 0 MR Created 2026-04-01 09:42 Last Author Commit 2026-04-08 14:04 First Review 2026-04-08 16:17 CR Approved 2026-04-08 14:12 Merged 2026-04-08 16:07 First Review -> CR Approved 0.0h Last Commit -> CR Approved 0.1h Created -> Merged 5.3d | ||||||
| adservio/services/notifications!8 | [S: ADS-6434][ADS-6886]: Marketing Notifications | 5/5 Deep | 10.7d | 3.7h | 15.9d | |
Repo adservio/services/notifications Author Dragoș Ivan Reviewers Daniel Onisoru, Edgar Alexa, George Murgoci Review Comments 9 Quality Notes 9 visible comments; 7 substantive comments; 3 reviewers; 17 post-review pushes; multi-point discussion Substantive Comments 7 Reviewer Count 3 Post-Review Pushes 17 MR Created 2026-03-17 17:17 Last Author Commit 2026-04-01 07:22 First Review 2026-04-01 11:06 CR Approved 2026-04-08 15:50 Merged 2026-04-08 16:06 First Review -> CR Approved 5.2d Last Commit -> CR Approved 5.4d Created -> Merged 16.0d | ||||||
| adservio/frontend!1660 | [ADS-6337] [Admin][Abonamente] - Hard Cancel Subscription | 3/5 Solid | 15.9d | 22.1h | 15.9d | |
Repo adservio/frontend Author Edgar Alexa Reviewers Dragoș Ivan Review Comments 1 Quality Notes 1 visible comment; 1 substantive comment; single reviewer; 1 post-review push Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 1 MR Created 2026-03-17 15:35 Last Author Commit 2026-04-07 15:50 First Review 2026-04-08 13:57 CR Approved 2026-04-08 13:56 Merged 2026-04-08 15:06 First Review -> CR Approved 0.0h Last Commit -> CR Approved 22.1h Created -> Merged 16.0d | ||||||
| adservio/subscriptions/backend!109 | [ADS-6337] [Admin][Abonamente] - Hard Cancel Subscription | 3/5 Solid | 5.2d | 25.1h | 7.1d | |
Repo adservio/subscriptions/backend Author Edgar Alexa Reviewers Daniel Onisoru Review Comments 1 Quality Notes 1 visible comment; 1 substantive comment; single reviewer; 3 post-review pushes Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 3 MR Created 2026-03-30 11:30 Last Author Commit 2026-04-03 15:31 First Review 2026-04-06 16:37 CR Approved 2026-04-08 13:51 Merged 2026-04-08 15:06 First Review -> CR Approved 45.2h Last Commit -> CR Approved 2.9d Created -> Merged 7.2d | ||||||
| adservio/frontend!1686 | [ADS-7092]: Absences - responsiveness | 3/5 Solid | 2.0d | 28.8h | 10.0d | |
Repo adservio/frontend Author Iuliana Gugeanu Reviewers Achim Stefan Review Comments 2 Quality Notes 2 visible comments; 2 substantive comments; single reviewer; 4 post-review pushes Substantive Comments 2 Reviewer Count 1 Post-Review Pushes 4 MR Created 2026-03-25 15:34 Last Author Commit 2026-03-26 11:42 First Review 2026-03-27 16:27 CR Approved 2026-04-08 15:19 Merged 2026-04-08 15:19 First Review -> CR Approved 8.0d Last Commit -> CR Approved 9.2d Created -> Merged 10.0d | ||||||
| adservio/web!2428 | [ADS-6434]: Marketing Notifications | 5/5 Deep | 21.6h | 34.0h | 11.1d | |
Repo adservio/web Author Dragoș Ivan Reviewers Daniel Onisoru, Andrei Dragan Review Comments 8 Quality Notes 8 visible comments; 4 substantive comments; 2 reviewers; 8 post-review pushes; multi-point discussion Substantive Comments 4 Reviewer Count 2 Post-Review Pushes 8 MR Created 2026-03-24 13:43 Last Author Commit 2026-03-24 01:19 First Review 2026-03-25 11:19 CR Approved 2026-04-08 15:50 Merged 2026-04-08 16:06 First Review -> CR Approved 10.2d Last Commit -> CR Approved 11.6d Created -> Merged 11.1d | ||||||
| adservio/web!2417 | [ADS-6284][ADS-7031] News files perms | 4/5 Strong | 10.4d | 2.3d | 16.1d | |
Repo adservio/web Author Ionut Ciolan Reviewers Andrei Dragan Review Comments 3 Quality Notes 3 visible comments; 3 substantive comments; single reviewer; 2 post-review pushes; multi-point discussion Substantive Comments 3 Reviewer Count 1 Post-Review Pushes 2 MR Created 2026-03-18 07:38 Last Author Commit 2026-03-30 10:36 First Review 2026-04-01 17:41 CR Approved 2026-04-09 09:52 Merged 2026-04-09 09:53 First Review -> CR Approved 5.7d Last Commit -> CR Approved 8.0d Created -> Merged 16.1d | ||||||
| adservio/frontend!1712 | [ADS-7207][FE/BE] - Modificari raport 'Situatie scolara' | 1/5 Very light | 3.0d | 3.0d | 3.0d | |
Repo adservio/frontend Author Iuliana Gugeanu Reviewers Ioana Ivan Review Comments 1 Quality Notes 1 visible comment; comments look lightweight; single reviewer Substantive Comments 0 Reviewer Count 1 Post-Review Pushes 0 MR Created 2026-04-06 14:41 Last Author Commit 2026-04-06 14:38 First Review 2026-04-09 15:16 CR Approved 2026-04-09 13:56 Merged 2026-04-09 15:12 First Review -> CR Approved 0.0h Last Commit -> CR Approved 3.0d Created -> Merged 3.0d | ||||||
No Visible Review Comment Audit
These merged MRs had no visible non-author GitLab comment under the current heuristic. Use this section to audit whether the gap is a real review-process issue or a GitLab traceability issue.
Total MRs27
With CR Label18
With Approval API5
- Open the MR link and check the Overview tab for
CR - Approvedand any approval widget signal. - Check Activity / Discussions for real human reviewer comments.
- If you only see system notes, merge notes, mentions, or bot activity, it stays in this audit set.
- If you find a genuine reviewer comment from someone other than the author, treat that MR as a false positive of this heuristic.
full audit table (27 MRs). Click again to collapse.
| adservio/uni/backend!176 | adservio/uni/backend | [ADS-6933] 'Catalog' - 'Promovare studenți' - Calcularea numarului de credite | Andrei Alexandru | 2026-04-06 | Yes | Yes |
| adservio/web!2438 | adservio/web | [ADS-7160][ADS-7158][ADS-7159][ADS-7161] log errors fixed | Ionut Ciolan | 2026-04-07 | Yes | |
| adservio/uni/backend!178 | adservio/uni/backend | [ADS-7192] Fisa disciplinei - Conținut Ordine elemente | Andrei Alexandru | 2026-04-07 | Yes | Yes |
| adservio/uni/backend!179 | adservio/uni/backend | [ADS-7175]: Calcul medie ECTS | Andrei Alexandru | 2026-04-07 | Yes | Yes |
| adservio/web!2442 | adservio/web | [ADS-6996]: Add CLI script to emit SCIM/CEAC import requested events | Andrei Dragan | 2026-04-07 | ||
| adservio/web!2443 | adservio/web | [HOTIFX] import school classes - copy user data query error | Ionut Ciolan | 2026-04-08 | ||
| adservio/docgen2/backend!105 | adservio/docgen2/backend | [ADS-7079]: Afisare procent pentru fiecare evaluationMethod | Dana Mihaela Maritca | 2026-04-08 | Yes | |
| adservio/docgen2/backend!104 | adservio/docgen2/backend | [ADS-7190]: Afisarea metodelor de predare intr-o singura celula | Dana Mihaela Maritca | 2026-04-08 | Yes | Yes |
| adservio/web!2444 | adservio/web | [Fix]: Refactor SCIM/CEAC event handling and improve tenant ID management | Andrei Dragan | 2026-04-08 | ||
| adservio/billing/backend!237 | adservio/billing/backend | [ADS-6337] [Admin][Abonamente] - Hard Cancel Subscription | Edgar Alexa | 2026-04-08 | Yes | |
| adservio/frontend!1697 | adservio/frontend | [ADS-7124]: Reexamination and Promotions responsiveness | Iuliana Gugeanu | 2026-04-08 | Yes | |
| adservio/frontend!1713 | adservio/frontend | [FE][ADS-7200]: Acommodations student view responsiveness | Iuliana Gugeanu | 2026-04-08 | Yes | |
| adservio/frontend!1717 | adservio/frontend | [ads-6337-fix] Removed unwanted newline | Edgar Alexa | 2026-04-08 | Yes | |
| adservio/frontend!1701 | adservio/frontend | [S: ADS-7139][ADS-7013]: Personal universitar - teste e2e | Dana Mihaela Maritca | 2026-04-08 | Yes | Yes |
| adservio/subscriptions/backend!111 | adservio/subscriptions/backend | [ADS-6434]: Marketing Notifications | Dragoș Ivan | 2026-04-08 | Yes | |
| adservio/helm2!232 | adservio/helm2 | ADS-6434 notifications helm chart | Raul Popovici | 2026-04-08 | ||
| adservio/web!2446 | adservio/web | [hotfix] Fix missing liceuID | Catalin Cojan | 2026-04-08 | ||
| adservio/web!2447 | adservio/web | [HOTIFX] import school classes - copy addresses | Ionut Ciolan | 2026-04-09 | ||
| adservio/frontend!1711 | adservio/frontend | [S: ADS-6822][ADS-7135]: Dss Incidents | Ioana Ivan | 2026-04-09 | ||
| adservio/billing/backend!240 | adservio/billing/backend | [ads-6337-tests] Fix assign service tests | Edgar Alexa | 2026-04-09 | ||
| adservio/admission/backend!114 | adservio/admission/backend | [ADS-7242] - fix statuses | George Murgoci | 2026-04-09 | Yes | |
| adservio/frontend!1720 | adservio/frontend | [ADS-7242] - fix statuses | George Murgoci | 2026-04-09 | Yes | |
| adservio/frontend!1719 | adservio/frontend | [ADS-7261]: Fix failing uni-messages test | Paul Tanasuca | 2026-04-09 | ||
| adservio/frontend!1722 | adservio/frontend | [ADS-7229][FE][Billing] - Modal Termeni și Condiții Adservio | Edgar Alexa | 2026-04-09 | Yes | |
| adservio/frontend!1715 | adservio/frontend | [S: ADS-6254][ADS-7244]: Allow View only on Scim Ceac | Ioana Ivan | 2026-04-09 | Yes | |
| adservio/uni/backend!180 | adservio/uni/backend | ADS-7207 Raport situatie scolara | Francisc Gabriel Virlan | 2026-04-09 | Yes | |
| adservio/uni/backend!175 | adservio/uni/backend | [ADS-7012] Code Sanity | Andrei Alexandru | 2026-04-09 | Yes |
Oldest Active Open MRs (> 48 Working Hours)
| adservio/web!2091 | adservio/web | Andrei Dragan | 191.5d | 5 | |
| adservio/devops/site-sentry!11 | adservio/devops/site-sentry | Daniel Onisoru | 175.0d | 0 | |
| adservio/helm2!137 | adservio/helm2 | Raul Popovici | 167.6d | 0 | |
| adservio/services/websocket!8 | adservio/services/websocket | Raul Popovici | 164.5d | 0 | |
| adservio/services/videothumb!5 | adservio/services/videothumb | Raul Popovici | 164.5d | 0 | |
| adservio/services/fet-generator!9 | adservio/services/fet-generator | Raul Popovici | 164.5d | 0 | |
| adservio/ai/backend!62 | adservio/ai/backend | Robert | 65.6d | 0 | |
| adservio/web!2323 | adservio/web | Andrei Dragan | 63.6d | 0 | |
| adservio/frontend!1556 | adservio/frontend | George Murgoci | 56.3d | 0 | |
| adservio/web!2344 | adservio/web | George Murgoci | 55.4d | 0 |
Longest Merged Cycles
| adservio/web!2417 | adservio/web | Ionut Ciolan | 16.1d | 4 | 3 |
| adservio/frontend!1660 | adservio/frontend | Edgar Alexa | 16.0d | 10 | 1 |
| adservio/services/notifications!8 | adservio/services/notifications | Dragoș Ivan | 16.0d | 102 | 9 |
| adservio/billing/backend!237 | adservio/billing/backend | Edgar Alexa | 13.9d | 7 | 0 |
| adservio/web!2428 | adservio/web | Dragoș Ivan | 11.1d | 8 | 8 |
| adservio/frontend!1686 | adservio/frontend | Iuliana Gugeanu | 10.0d | 4 | 2 |
| adservio/subscriptions/backend!109 | adservio/subscriptions/backend | Edgar Alexa | 7.1d | 20 | 1 |
| adservio/helm2!232 | adservio/helm2 | Raul Popovici | 6.2d | 13 | 0 |
| adservio/frontend!1697 | adservio/frontend | Iuliana Gugeanu | 6.1d | 7 | 0 |
| adservio/frontend!1698 | adservio/frontend | Dragoș Ivan | 5.3d | 99 | 9 |
Methodology And Limits
- This report uses visible non-author GitLab comments as the strongest review-start proxy.
- GitLab approval API coverage is shown separately; missing approval API data should be read as traceability gap, not proof that no approval happened.
- Review completion uses the first `CR - Approved` label-add event after review starts when GitLab label history provides one; otherwise it falls back to merge time.
- Last-author-commit metrics use the latest non-merge MR commit authored by the MR author strictly before review starts.
- Timing metrics in this report exclude Saturday and Sunday hours using the Europe/Bucharest calendar.
- Review-quality scoring is heuristic: it rewards visible substantive comments, multiple reviewers, and post-review pushes, and it penalizes large MRs with shallow visible discussion.
- `Active open backlog rate` excludes draft MRs and uses a > 48 working-hour age threshold.
- Open MR backlog age is a queue-health signal, not proof that every old open MR is actively waiting for review right now.