GitLab-backed analysis

Adservio Code Review Analysis

A read-only analysis of recent merge request review behavior in GitLab, focused on visible review discussion, reviewer distribution, queue health, MR size, and traceability gaps.

Period: 2026-05-16 07:00 to 2026-05-24 20:11
Primary source: GitLab merge request metadata, notes, labels, commits, and approvals endpoints.

Bottom line: review throughput is not the main risk here; traceability and queue hygiene are. The team is still merging code, but most merges leave no durable visible review trail and the open queue is overwhelmingly stale.

What Matters

  • Traceability is the clearest control gap: 51 of 61 merged MRs (83.6%) showed no visible non-author review comment in GitLab.
  • `CR - Approved` is currently too weak as evidence on its own: 52.5% of merged MRs carried that label without any visible review discussion.
  • Queue health is poor: 76.5% of active open MRs are already older than 48 working hours. The oldest example is adservio/web!2091 at 221.5d open.
  • Visible review capacity is thin and concentrated: only 11 visible review touches were detected in the whole window, and the top 3 reviewers handled 90.9% of them.
  • adservio/frontend is the highest-volume review surface with 33 merged MRs and only 15.2% visible review coverage.
  • MR size is not the main story: median changed files were 4, and only 14.8% of merged MRs were above 20 files. Even the slowest merged example, adservio/uni/backend!172, took 34.5d with 32 changed files, so the dominant problem still looks like review discipline and queue ownership rather than consistently oversized MRs.

Leadership Analysis

  • This does not read like a slow-review system. The median last-author-commit to first-review time was 6.3h, so the dominant weakness is decision recording and merge discipline, not reviewer reaction speed.
  • With 76.5% of active MRs already stale, the open list is functioning more like inventory than prioritization support. adservio/web!2091 being open for 221.5d is a strong sign that ownership and review handoffs are not being actively reset.
  • Reviewer concentration is now a resilience issue, not just a fairness issue. When the top 3 reviewers carry 90.9% of visible touches, review quality, continuity, and queue health all become sensitive to a very small set of people.
  • The spread between a 4-file median MR and a 34.5d longest merged cycle (adservio/uni/backend!172, 32 changed files) suggests a few ownership-heavy exceptions are dragging on outside normal flow. Those should be managed as explicit escalations, not left to age inside the common queue.

Recommended Actions

  • Make one durable review artifact mandatory before merge: a substantive non-author GitLab review comment, a recorded approval, or both. A label alone should no longer count as sufficient evidence. The approval API coverage is also low, so the fix should include tooling or policy that leaves an auditable trace by default.
  • Run a stale-MR reset on anything older than 48 working hours: close abandoned work, re-confirm owner and reviewer on the rest, and turn the open list back into a real queue instead of a parking lot. Start with adservio/web!2091 and the rest of the oldest backlog because their age now obscures whether they are still real priorities.
  • Put adservio/devops/iac under explicit review guardrails for the next cycle. It combines enough volume with weak visible review coverage, which makes it the best place to tighten the process and see impact quickly.
  • Broaden the reviewer bench beyond Dragoș Ivan and the current small reviewer set. The present concentration is a continuity risk and will keep queue health fragile when one person is away.

Improvement Ideas

  • Set explicit operating standards for the next quarter: require one auditable peer-review artifact before merge, target first review inside one working day for active MRs, and keep the stale active backlog below 15%. What gets measured this clearly is far more likely to improve.
  • Run a four-week process experiment on adservio/devops/iac: dedicated reviewer-of-the-week coverage, explicit reviewer assignment at MR creation, and a lightweight weekly audit of silent merges. It is the highest-yield place to test whether better ownership changes the data.
  • Create a reviewer rotation with named backup coverage for the busiest repos. Good review systems depend on redundancy, not heroics, and rotation is the fastest way to lower reviewer bus factor without slowing delivery.

Supporting Evidence

  • 51 of 61 merged MRs (83.6%) had no visible non-author review comment in GitLab.
  • 42 of 61 merged MRs (68.9%) carried the `CR - Approved` label.
  • 32 merged MRs (52.5%) were labeled `CR - Approved` without any visible non-author review comment.
  • 14.8% of merged MRs changed more than 20 files, while 8.2% changed more than 50 files.
  • Among MRs with visible review discussion, the median last-author-commit to first-review time was 6.3h.
  • The median last-author-commit to `CR - Approved` time was 7.3h.
  • The top 3 reviewers accounted for 90.9% of visible review touches.
  • 39 of 51 active open MRs (76.5%) were older than 48 working hours.
Merged MRs
Merged MRs inside the analysis window.
61
Open MRs
All currently open group MRs.
54
Active open MRs
Open MRs excluding drafts.
51
Draft open MRs
Open MRs marked draft/WIP.
3
Visible review rate
Merged MRs with at least one visible non-author GitLab comment.
16.4%
Merged without visible review comment
Merged MRs with zero visible non-author comments.
83.6%
CR - Approved label coverage
Merged MRs carrying the CR-approved label.
68.9%
Approval API coverage
Merged MRs with at least one approver in the GitLab approvals API.
16.4%
CR - Approved without visible review comment
CR-approved MRs with no visible non-author comment.
52.5%
Median MR created -> first review
Working time from MR creation to first visible non-author comment.
7.0h
Median last author commit -> first review
Working time from last author commit before review to first visible non-author comment.
6.3h
Median first review -> CR - Approved
Working time from first visible comment to CR-approved label after review start, else merge.
2.4h
Median MR created -> CR - Approved
Working time from MR creation to CR-approved label after review start, else merge.
8.5h
Median last author commit -> CR - Approved
Working time from last author commit before review to CR-approved label after review start, else merge.
7.3h
Median MR created -> merged
Working time from MR creation to merge.
21.4h
Median changed files
Median GitLab `changes_count` value.
4
MRs > 5 files
Merged MRs where `changes_count` is above 5.
42.6%
MRs > 10 files
Merged MRs where `changes_count` is above 10.
27.9%
MRs > 20 files
Merged MRs where `changes_count` is above 20.
14.8%
MRs > 50 files
Merged MRs where `changes_count` is above 50.
8.2%
Top 3 reviewer touch share
Share of visible review touches handled by the top 3 reviewers.
90.9%
Active open backlog rate
Non-draft open MRs older than 48 working hours.
76.5%

These headline timing medians bring back the anchor-to-anchor numbers directly, using working time with weekends excluded.

Median MR created -> first review7.0h
Median last author commit -> first review6.3h
Median MR created -> CR - Approved8.5h
Median first review -> CR - Approved2.4h
Median last author commit -> CR - Approved7.3h
Median MR created -> merged21.4h
Dragoș Ivan6854.5%
Ioana Ivan21018.2%
George Murgoci2518.2%
Alex Murarescu189.1%
adservio/frontend3315.2%78.8%3
adservio/admission/backend650.0%66.7%15.0
adservio/devops/iac60.0%33.3%3.5
adservio/web50.0%80.0%4
adservio/helm230.0%33.3%1
adservio/audit20.0%0.0%1.5
adservio/billing/backend250.0%100.0%15.5
adservio/uni/backend20.0%50.0%16.5
adservio/docgen2/backend10.0%100.0%4
adservio/forms/backend1100.0%100.0%6

Visible Review Discussion MRs

Compact by default: key CR metrics stay visible, and each row expands inline for the full audit trail. The table starts sorted by Last Commit -> First Review.

Details
adservio/admission/backend!139[ADS-7425]: Session Fees5/5 Deep0.9h0.2h1.5h
adservio/frontend!1826[hotfix]-form validation fixes4/5 Strong3.7h1.5h6.5h
adservio/frontend!1828[ADS-7625] Add post message on close for Create News Modal3/5 Solid1.9h1.8h2.0h
adservio/forms/backend!17[hotfix]-form validation fixes3/5 Solid3.3h2.3h6.5h
adservio/admission/backend!140[hotfix]-form validation fixes3/5 Solid3.6h3.7h5.0h
adservio/admission/backend!144[ADS-7373] - new columns on exported csv/pdf/excel1/5 Very light10.3h9.0h10.4h
adservio/frontend!1813[ADS-7425]: Session Fees4/5 Strong19.9h18.8h21.7h
adservio/billing/backend!242[ADS-5949] Upgraded local processor for subscriptions3/5 Solid6.9d19.4h20.0d
adservio/frontend!1827[ADS-6870] Ștergere note în perioade blocate3/5 Solid34.2h27.8h2.1d
adservio/frontend!1766[S - ADS-6661][Situatie scolara] - US4 Echivalari4/5 Strong9.4d42.3h9.5d

No Visible Review Comment Audit

These merged MRs had no visible non-author GitLab comment under the current heuristic. Use this section to audit whether the gap is a real review-process issue or a GitLab traceability issue.

Total MRs51
With CR Label32
With Approval API9
  • Open the MR link and check the Overview tab for CR - Approved and any approval widget signal.
  • Check Activity / Discussions for real human reviewer comments.
  • If you only see system notes, merge notes, mentions, or bot activity, it stays in this audit set.
  • If you find a genuine reviewer comment from someone other than the author, treat that MR as a false positive of this heuristic.
full audit table (51 MRs). Click again to collapse.
adservio/uni/backend!172adservio/uni/backend[S: ADS-6661][ADS-7060]: [Catalog][Situatie scolara] - US4 EchivalariAndrei Alexandru2026-05-17Yes
adservio/frontend!1817adservio/frontend[ADS-7586]: Loading incorect pe class subjectIoana Ivan2026-05-18
adservio/web!2493adservio/web[ADS-4701] get elevi - added e2cIsActive on class details responseIonut Ciolan2026-05-18YesYes
adservio/frontend!1809adservio/frontend[ADS-4701] Nu funcționează adăugarea unei suprascrieri în Catalogul PDF al...Petronel Pavel2026-05-18YesYes
adservio/frontend!1811adservio/frontend[ADS-4592] Setare by default a materiilor de la -Selectați noile materii pe...Petronel Pavel2026-05-18Yes
adservio/helm2!247adservio/helm2lower web HPA cpu utilization target from 100% to 80%Rojan Shrestha2026-05-18YesYes
adservio/frontend!1820adservio/frontend[ADS-7617] SelectOrganizationsTree UI improvements, Director dashboard updatesAlex Murarescu2026-05-18Yes
adservio/frontend!1803adservio/frontend[ADS-7524]: Routes for MobileIoana Ivan2026-05-18Yes
adservio/frontend!1810adservio/frontend[ADS-7164]: Taxe UI ResponsiveIuliana Gugeanu2026-05-18Yes
adservio/frontend!1818adservio/frontend[ADS-7225] - creare/editare manuala candidatiGeorge Murgoci2026-05-18
adservio/admission/backend!137adservio/admission/backend[ADS-7225] - creare/editare manuala candidatiGeorge Murgoci2026-05-18
adservio/devops/iac!27adservio/devops/iacadd readonly performance insgihts for monitoring roleRojan Shrestha2026-05-18YesYes
adservio/frontend!1825adservio/frontendadmission permissions/fees fixesGeorge Murgoci2026-05-18
adservio/audit!11adservio/audit[date-hotfix] Date hotfixEdgar Alexa2026-05-18
adservio/audit!12adservio/audit[audit-log-headers] logged headersEdgar Alexa2026-05-18
adservio/frontend!1823adservio/frontendRemove default start date on payment obligationsAchim Stefan2026-05-19Yes
adservio/frontend!1824adservio/frontend[ADS-2126] Notifications/Tooltips display wrong professorPetronel Pavel2026-05-19Yes
adservio/frontend!1821adservio/frontend[ADS-7530] Login improvementsPetronel Pavel2026-05-19Yes
adservio/frontend!1814adservio/frontend[ADS-7480] [Financiar] Numele bancii si cont IBANEdgar Alexa2026-05-19Yes
adservio/docgen2/backend!121adservio/docgen2/backend[ADS-7480] [Financiar] Numele bancii si cont IBANEdgar Alexa2026-05-19Yes
adservio/billing/backend!246adservio/billing/backend[ADS-7480] [Financiar] Numele bancii si cont IBANEdgar Alexa2026-05-19Yes
adservio/devops/iac!26adservio/devops/iacEnforce per-database isolation for Postgres app users on stagingRojan Shrestha2026-05-19YesYes
adservio/frontend!1815adservio/frontend[ADS-5949] Local processorEdgar Alexa2026-05-19Yes
adservio/frontend!1829adservio/frontend[ADS-6329] Modificare denumire ”Învoire concursuri”Petronel Pavel2026-05-19Yes
adservio/admission/backend!141adservio/admission/backendremoved dead applciationf ees codeGeorge Murgoci2026-05-19
adservio/web!2498adservio/web[ADS-7447][ADS-7611][ADS-7489][ADS-7117] log errorsIonut Ciolan2026-05-19YesYes
adservio/web!2495adservio/web[ADS-4569] count student absences per classIonut Ciolan2026-05-19YesYes
adservio/frontend!1836adservio/frontend[ADS-6802] - Userii cu permisiune de manager ar trebui sa poata adauga procente la o disciplinaAchim Stefan2026-05-20Yes
adservio/helm2!250adservio/helm2add cloudwatch as datasoure for grafan to fetch db metricsRojan Shrestha2026-05-20
adservio/devops/iac!28adservio/devops/iacadd grafana cloudwatch IRSA role and policy for productionRojan Shrestha2026-05-20Yes
adservio/devops/iac!29adservio/devops/iacadd aws-apn-id default tag + stabilize bastion/CSI lifecycleRojan Shrestha2026-05-20Yes
adservio/frontend!1800adservio/frontend[ADS-7222]: Studenti - teste automate fixDana Mihaela Maritca2026-05-20Yes
adservio/frontend!1835adservio/frontend[ADS-7523] - fixed default orderring on caniddates tableGeorge Murgoci2026-05-20Yes
adservio/frontend!1832adservio/frontendAdmission bugfixesGeorge Murgoci2026-05-20Yes
adservio/admission/backend!143adservio/admission/backend[ADS-7459] added email/phone first/last name to applicationsGeorge Murgoci2026-05-20Yes
adservio/frontend!1831adservio/frontend[ADS-7459] added email/phone first/last name to applicationsGeorge Murgoci2026-05-20Yes
adservio/devops/iac!30adservio/devops/iacupgrade database and disable multi-azRojan Shrestha2026-05-20
adservio/frontend!1840adservio/frontendFix contest exemption E2E copy driftValentin Pal2026-05-20
adservio/helm2!249adservio/helm2raise web maxReplicas from 20 to 25 in productionRojan Shrestha2026-05-21
adservio/web!2502adservio/web[HOTFIX] School config - import & sync permIonut Ciolan2026-05-21Yes
adservio/frontend!1843adservio/frontend[ADS-7545]: Mesaj de alerta la dezactivarea disciplinei optionale modificat la 3 secundeIuliana Gugeanu2026-05-21Yes
adservio/frontend!1844adservio/frontendimports permissions fixAchim Stefan2026-05-21Yes
adservio/web!2501adservio/web[ADS-7550][ADS-4876][ADS-4929] Update foaie matricolaMarian Andrei2026-05-21
adservio/devops/iac!31adservio/devops/iacprod RDS: catalog2 downgrade + tune only the firing alarmsRojan Shrestha2026-05-21
adservio/frontend!1845adservio/frontend[ADS-5289] Questionnaires - selector persoanePetronel Pavel2026-05-22Yes
adservio/frontend!1847adservio/frontend[ADS-4235] Se face un request pentru wellbeing cand nu este cazulPetronel Pavel2026-05-22Yes
adservio/frontend!1850adservio/frontendimports permissions fixAchim Stefan2026-05-22Yes
adservio/uni/backend!198adservio/uni/backend[ADS-7569] Sincronizare alocare grupa studentAndrei Alexandru2026-05-22
adservio/frontend!1849adservio/frontendFix Cypress exemption label importMarian Andrei2026-05-24
adservio/frontend!1848adservio/frontendFix Cypress exemption label importMarian Andrei2026-05-24
adservio/frontend!1841adservio/frontendRefactor Cypress configuration and cleanupDaniel Onisoru2026-05-24

Oldest Active Open MRs (> 48 Working Hours)

adservio/web!2091adservio/webAndrei Dragan221.5d5
adservio/helm2!137adservio/helm2Raul Popovici197.6d0
adservio/services/websocket!8adservio/services/websocketRaul Popovici194.5d0
adservio/services/videothumb!5adservio/services/videothumbRaul Popovici194.5d0
adservio/services/fet-generator!9adservio/services/fet-generatorRaul Popovici194.5d0
adservio/ai/backend!62adservio/ai/backendRobert95.6d0
adservio/frontend!1556adservio/frontendGeorge Murgoci86.3d0
adservio/web!2344adservio/webGeorge Murgoci85.4d0
adservio/library/backend!26adservio/library/backendRaul Popovici65.4d0
adservio/subscriptions/backend!103adservio/subscriptions/backendEdgar Alexa63.4d4
adservio/uni/backend!172adservio/uni/backendAndrei Alexandru34.5d320
adservio/billing/backend!242adservio/billing/backendEdgar Alexa20.0d172
adservio/frontend!1766adservio/frontendAchim Stefan10.0d485
adservio/frontend!1800adservio/frontendDana Mihaela Maritca6.2d10
adservio/admission/backend!137adservio/admission/backendGeorge Murgoci6.1d610
adservio/devops/iac!26adservio/devops/iacRojan Shrestha3.9d80
adservio/frontend!1803adservio/frontendIoana Ivan3.1d150
adservio/web!2495adservio/webIonut Ciolan2.4d60
adservio/frontend!1827adservio/frontendPetronel Pavel2.1d81
adservio/web!2493adservio/webIonut Ciolan47.6h20

Methodology And Limits

  • This report uses visible non-author GitLab comments as the strongest review-start proxy.
  • GitLab approval API coverage is shown separately; missing approval API data should be read as traceability gap, not proof that no approval happened.
  • Review completion uses the first `CR - Approved` label-add event after review starts when GitLab label history provides one; otherwise it falls back to merge time.
  • Last-author-commit metrics use the latest non-merge MR commit authored by the MR author strictly before review starts.
  • Timing metrics in this report exclude Saturday and Sunday hours using the Europe/Bucharest calendar.
  • Review-quality scoring is heuristic: it rewards visible substantive comments, multiple reviewers, and post-review pushes, and it penalizes large MRs with shallow visible discussion.
  • `Active open backlog rate` excludes draft MRs and uses a > 48 working-hour age threshold.
  • Open MR backlog age is a queue-health signal, not proof that every old open MR is actively waiting for review right now.