GitLab-backed analysis

Adservio Code Review Analysis

A read-only analysis of recent merge request review behavior in GitLab, focused on visible review discussion, reviewer distribution, queue health, MR size, and traceability gaps.

Period: 2026-05-30 07:00 to 2026-06-08 02:18
Primary source: GitLab merge request metadata, notes, labels, commits, and approvals endpoints.

Bottom line: review throughput is not the main risk here; traceability and queue hygiene are. The team is still merging code, but most merges leave no durable visible review trail and the open queue is overwhelmingly stale.

What Matters

  • Traceability is the clearest control gap: 50 of 58 merged MRs (86.2%) showed no visible non-author review comment in GitLab.
  • `CR - Approved` is currently too weak as evidence on its own: 51.7% of merged MRs carried that label without any visible review discussion.
  • Queue health is poor: 81.1% of active open MRs are already older than 48 working hours. The oldest example is adservio/web!2091 at 231.6d open.
  • Visible review capacity is thin and concentrated: only 8 visible review touches were detected in the whole window, and the top 3 reviewers handled 62.5% of them.
  • adservio/web is the highest-volume review surface with 19 merged MRs and only 10.5% visible review coverage. adservio/frontend is the next meaningful flow at 14 merges and 7.1% visible review coverage.
  • MR size is not the main story: median changed files were 2.0, and only 12.1% of merged MRs were above 20 files. Even the slowest merged example, adservio/web!2409, took 60.3d with 192 changed files, so the dominant problem still looks like review discipline and queue ownership rather than consistently oversized MRs.

Leadership Analysis

  • The operating rhythm is serviceable at the median (13.0h created-to-merged), which means the biggest leverage is improving process fidelity rather than pushing for even more raw throughput.
  • With 81.1% of active MRs already stale, the open list is functioning more like inventory than prioritization support. adservio/web!2091 being open for 231.6d is a strong sign that ownership and review handoffs are not being actively reset.
  • Reviewer concentration is now a resilience issue, not just a fairness issue. When the top 3 reviewers carry 62.5% of visible touches, review quality, continuity, and queue health all become sensitive to a very small set of people.
  • The spread between a 2.0-file median MR and a 60.3d longest merged cycle (adservio/web!2409, 192 changed files) suggests a few ownership-heavy exceptions are dragging on outside normal flow. Those should be managed as explicit escalations, not left to age inside the common queue.

Recommended Actions

  • Make one durable review artifact mandatory before merge: a substantive non-author GitLab review comment, a recorded approval, or both. A label alone should no longer count as sufficient evidence. The approval API coverage is also low, so the fix should include tooling or policy that leaves an auditable trace by default.
  • Run a stale-MR reset on anything older than 48 working hours: close abandoned work, re-confirm owner and reviewer on the rest, and turn the open list back into a real queue instead of a parking lot. Start with adservio/web!2091 and the rest of the oldest backlog because their age now obscures whether they are still real priorities.
  • Put adservio/devops/iac under explicit review guardrails for the next cycle. It combines enough volume with weak visible review coverage, which makes it the best place to tighten the process and see impact quickly.
  • Broaden the reviewer bench beyond Valentin Pal and the current small reviewer set. The present concentration is a continuity risk and will keep queue health fragile when one person is away.

Improvement Ideas

  • Set explicit operating standards for the next quarter: require one auditable peer-review artifact before merge, target first review inside one working day for active MRs, and keep the stale active backlog below 15%. What gets measured this clearly is far more likely to improve.
  • Run a four-week process experiment on adservio/devops/iac: dedicated reviewer-of-the-week coverage, explicit reviewer assignment at MR creation, and a lightweight weekly audit of silent merges. It is the highest-yield place to test whether better ownership changes the data.
  • Create a reviewer rotation with named backup coverage for the busiest repos. Good review systems depend on redundancy, not heroics, and rotation is the fastest way to lower reviewer bus factor without slowing delivery.

Supporting Evidence

  • 50 of 58 merged MRs (86.2%) had no visible non-author review comment in GitLab.
  • 37 of 58 merged MRs (63.8%) carried the `CR - Approved` label.
  • 30 merged MRs (51.7%) were labeled `CR - Approved` without any visible non-author review comment.
  • 12.1% of merged MRs changed more than 20 files, while 8.6% changed more than 50 files.
  • Among MRs with visible review discussion, the median last-author-commit to first-review time was 15.2h.
  • The median last-author-commit to `CR - Approved` time was 22.4h.
  • The top 3 reviewers accounted for 62.5% of visible review touches.
  • 43 of 53 active open MRs (81.1%) were older than 48 working hours.
Merged MRs
Merged MRs inside the analysis window.
58
Open MRs
All currently open group MRs.
58
Active open MRs
Open MRs excluding drafts.
53
Draft open MRs
Open MRs marked draft/WIP.
5
Visible review rate
Merged MRs with at least one visible non-author GitLab comment.
13.8%
Merged without visible review comment
Merged MRs with zero visible non-author comments.
86.2%
CR - Approved label coverage
Merged MRs carrying the CR-approved label.
63.8%
Approval API coverage
Merged MRs with at least one approver in the GitLab approvals API.
20.7%
CR - Approved without visible review comment
CR-approved MRs with no visible non-author comment.
51.7%
Median MR created -> first review
Working time from MR creation to first visible non-author comment.
34.1h
Median last author commit -> first review
Working time from last author commit before review to first visible non-author comment.
15.2h
Median first review -> CR - Approved
Working time from first visible comment to CR-approved label after review start, else merge.
1.9h
Median MR created -> CR - Approved
Working time from MR creation to CR-approved label after review start, else merge.
45.1h
Median last author commit -> CR - Approved
Working time from last author commit before review to CR-approved label after review start, else merge.
22.4h
Median MR created -> merged
Working time from MR creation to merge.
13.0h
Median changed files
Median GitLab `changes_count` value.
2.0
MRs > 5 files
Merged MRs where `changes_count` is above 5.
31.0%
MRs > 10 files
Merged MRs where `changes_count` is above 10.
15.5%
MRs > 20 files
Merged MRs where `changes_count` is above 20.
12.1%
MRs > 50 files
Merged MRs where `changes_count` is above 50.
8.6%
Top 3 reviewer touch share
Share of visible review touches handled by the top 3 reviewers.
62.5%
Active open backlog rate
Non-draft open MRs older than 48 working hours.
81.1%

These headline timing medians bring back the anchor-to-anchor numbers directly, using working time with weekends excluded.

Median MR created -> first review34.1h
Median last author commit -> first review15.2h
Median MR created -> CR - Approved45.1h
Median first review -> CR - Approved1.9h
Median last author commit -> CR - Approved22.4h
Median MR created -> merged13.0h
Valentin Pal3437.5%
Andrei Dragan1212.5%
Dragoș Ivan1112.5%
Daniel Onisoru1812.5%
Cosmin Olaru1112.5%
Ioana Ivan1112.5%
adservio/web1910.5%63.2%2
adservio/frontend147.1%92.9%5.5
adservio/helm21030.0%40.0%2.0
adservio/admission/backend333.3%100.0%2
adservio/devops/iac30.0%0.0%10
adservio/docgen2/backend30.0%100.0%5
adservio/accommodations/backend20.0%0.0%1.0
adservio/social250.0%50.0%42.5
adservio/devops/site-sentry10.0%0.0%70
adservio/uni/backend10.0%100.0%3

Visible Review Discussion MRs

Compact by default: key CR metrics stay visible, and each row expands inline for the full audit trail. The table starts sorted by Last Commit -> First Review.

Details
adservio/admission/backend!150[ADS-6611] - rmq events for application statuses/mesages3/5 Solid46.0h0.6h2.0d
adservio/frontend!1896[ADS-7725][ADS-7769] Modificari diploma simpla2/5 Light26.0h2.4h26.9h
adservio/helm2!263add topologySpreadConstraints to web deployment for even pod distribution3/5 Solid3.3h3.3h2.3h
adservio/helm2!262bump HPA maxrepl for docgen2-api (12→24) and notifications-event-manager (3→6)2/5 Light3.4h3.4h2.4h
adservio/helm2!261fix(node-local-dns): NXDOMAIN external PTR lookups via clusterReverseZones3/5 Solid26.9h27.0h2.9d
adservio/web!2537[ADS-7697]: Fix subject transfers for multiple teachers on same subject2/5 Light41.3h41.3h41.4h
adservio/web!2500[ADS-7621] class transfers indicators + school transfer changes3/5 Solid2.8d2.8d5.9d
adservio/social!20[ADS-7518] Cache controller4/5 Strong3.9d2.9d9.1d

No Visible Review Comment Audit

These merged MRs had no visible non-author GitLab comment under the current heuristic. Use this section to audit whether the gap is a real review-process issue or a GitLab traceability issue.

Total MRs50
With CR Label30
With Approval API8
  • Open the MR link and check the Overview tab for CR - Approved and any approval widget signal.
  • Check Activity / Discussions for real human reviewer comments.
  • If you only see system notes, merge notes, mentions, or bot activity, it stays in this audit set.
  • If you find a genuine reviewer comment from someone other than the author, treat that MR as a false positive of this heuristic.
full audit table (50 MRs). Click again to collapse.
adservio/accommodations/backend!69adservio/accommodations/backend[HOTFIX] Accommodations school config middlewareIonut Ciolan2026-06-02
adservio/frontend!1884adservio/frontend[ADS-7742][Cazari] - Filtrul dupa camera si camin nu returneaza studentiiAchim Stefan2026-06-02Yes
adservio/accommodations/backend!70adservio/accommodations/backend[HOTFIX] Accommodations subscriptions middlewareIonut Ciolan2026-06-02
adservio/web!2529adservio/web[ADS-7619]: Check FLAG_DOC_CLASSBOOK_ARCHIVES and...Ioana Ivan2026-06-02
adservio/frontend!1885adservio/frontend[ADS-7619]: Hotfix check all permissions for gradebookIoana Ivan2026-06-02
adservio/frontend!1886adservio/frontendAccommodations hide payment buttonAchim Stefan2026-06-02Yes
adservio/web!2530adservio/web[HOTFIX] removed otel span implicit attributeIonut Ciolan2026-06-02
adservio/web!2531adservio/web[ADS-7533] Grades statistics - final average missing variabileIonut Ciolan2026-06-02
adservio/web!2532adservio/web[ADS-7515] linked accounts validationIonut Ciolan2026-06-02
adservio/frontend!1882adservio/frontend[ADS-7718] Modalul de setari tipuri note nu functioneaza corect pe mobilePetronel Pavel2026-06-02YesYes
adservio/devops/iac!33adservio/devops/iacADS-7669: CloudFront + S3 CDN modulesRojan Shrestha2026-06-03
adservio/frontend!1888adservio/frontend[ADS-7591] Nu se inregistreaza transferul daca numarul de transfer are in componenta semnePetronel Pavel2026-06-03Yes
adservio/web!2534adservio/web[ADS-7494] Calendar event - code refactorIonut Ciolan2026-06-03YesYes
adservio/web!2521adservio/web[ADS-7274] Implementare afisare numar matricol pentru rolurile de elev si parintePetronel Pavel2026-06-03YesYes
adservio/helm2!264adservio/helm2ADS-7760: seal slack webhook for TUIASI alertmanagerRojan Shrestha2026-06-03
adservio/web!2528adservio/web[ADS-7591][ADS-2346] Subject transfer - show error if student is deleted + class transfer number to be stringIonut Ciolan2026-06-03Yes
adservio/web!2513adservio/web[ADS-6512] Listare Statistici cu antetul scoliiPetronel Pavel2026-06-03Yes
adservio/frontend!1839adservio/frontend[ADS-7621] Management clasa - Documente - Catalogul claseiPetronel Pavel2026-06-03Yes
adservio/frontend!1872adservio/frontend[ADS-7274] Implementare afisare numar matricol pentru rolurile de elev si parintePetronel Pavel2026-06-03YesYes
adservio/helm2!265adservio/helm2ADS-7760: remove slack block from helm/overrides-tuiasi.yamlRojan Shrestha2026-06-03
adservio/frontend!1892adservio/frontend[ADS-2172]: Fix styles on print modeIoana Ivan2026-06-03Yes
adservio/web!2535adservio/web[ADS-2172]: Fix styles on print modeIoana Ivan2026-06-03Yes
adservio/devops/iac!34adservio/devops/iacAds 7669 cloudfront s3 implementationRojan Shrestha2026-06-03
adservio/devops/iac!35adservio/devops/iacupgrade rdsRojan Shrestha2026-06-03
adservio/devops/site-sentry!12adservio/devops/site-sentry[ADS-7668] [ADS-7669] Implement S3 publishingDaniel Onisoru2026-06-03
adservio/admission/backend!151adservio/admission/backend[ads-7743] - searh candidate by first+last nameGeorge Murgoci2026-06-04Yes
adservio/admission/backend!152adservio/admission/backend[ADS-7773] - fixed filer and delete candiodateGeorge Murgoci2026-06-04Yes
adservio/frontend!1894adservio/frontend[ADS-6611] - added mesaje si evenimente tab back /filterring/removed optional...George Murgoci2026-06-04Yes
adservio/helm2!267adservio/helm2[ADS-6611] -Publish admission application...Daniel Onisoru2026-06-04Yes
adservio/web!2533adservio/web[S: ADS-6611][ADS-7678] [Admitere v2] - Notificari la modulul admitereCatalin Cojan2026-06-04Yes
adservio/helm2!251adservio/helm2[ADS-7518] Cache ControllerAlex Murarescu2026-06-04Yes
adservio/web!2504adservio/web[ADS-7518] [BE/PHP] Creare controller de cacheCatalin Cojan2026-06-04Yes
adservio/web!2538adservio/web[ADS-7757] School Transcript - fixed estimated average for moduleIonut Ciolan2026-06-04YesYes
adservio/social!24adservio/socialcache hotfixAlex Murarescu2026-06-04
adservio/frontend!1830adservio/frontend[Laravel] Moved nationalities nomenclature to laravel backendDaniel Onisoru2026-06-04YesYes
adservio/helm2!246adservio/helm2Laravel for webDaniel Onisoru2026-06-04
adservio/web!2409adservio/web[ADS-] Add laravel to webDaniel Onisoru2026-06-04
adservio/web!2541adservio/web[ADS-7512] Fix missing parent name from SMS modalMarian Andrei2026-06-05
adservio/helm2!266adservio/helm2ADS-7756: raise web minrepl to 24 and lower CPU target to 60 for prodRojan Shrestha2026-06-05
adservio/docgen2/backend!130adservio/docgen2/backend[ADS-7774]: Count absences from matPurtare=1 subjects and ignore cmcClassbookVisible=0 subjects.Ioana Ivan2026-06-05Yes
adservio/frontend!1895adservio/frontend[ADS-7752]: Add tennant ID to portfolio uploadIoana Ivan2026-06-05YesYes
adservio/web!2542adservio/web[ADS-7777] classroom subjects order permIonut Ciolan2026-06-05
adservio/web!2539adservio/web[ADS-7776] Teacher groups native messageIonut Ciolan2026-06-05Yes
adservio/frontend!1890adservio/frontend[ADS-7277] Vizualizare full screenPetronel Pavel2026-06-05Yes
adservio/frontend!1883adservio/frontend[ADS-7651]: Add new route for history - teacher - last 5 actions.Ioana Ivan2026-06-05Yes
adservio/docgen2/backend!131adservio/docgen2/backend[ADS-7795]: Afiseaza examen specialitate cu vigulaIoana Ivan2026-06-05YesYes
adservio/web!2536adservio/web[ADS-7725][ADS-7768] Teacher entitling addedIonut Ciolan2026-06-05Yes
adservio/docgen2/backend!129adservio/docgen2/backend[ADS-7725][ADS-7769] Modificari diploma simplaPetronel Pavel2026-06-05Yes
adservio/helm2!269adservio/helm2ADS-7809: add phpfpmLaravel CPU/memory requests for prod (unblocks KEDA)Rojan Shrestha2026-06-05
adservio/uni/backend!204adservio/uni/backend[ADS-7808] HOTFIX: intrari duplicate inchidere_catalog_grupaAndrei Alexandru2026-06-05Yes

Oldest Active Open MRs (> 48 Working Hours)

adservio/web!2091adservio/webAndrei Dragan231.6d5
adservio/helm2!137adservio/helm2Raul Popovici207.7d0
adservio/services/websocket!8adservio/services/websocketRaul Popovici204.6d0
adservio/services/videothumb!5adservio/services/videothumbRaul Popovici204.6d0
adservio/services/fet-generator!9adservio/services/fet-generatorRaul Popovici204.6d0
adservio/ai/backend!62adservio/ai/backendRobert105.7d0
adservio/frontend!1556adservio/frontendGeorge Murgoci96.4d0
adservio/web!2344adservio/webGeorge Murgoci95.5d0
adservio/library/backend!26adservio/library/backendRaul Popovici75.5d0
adservio/subscriptions/backend!103adservio/subscriptions/backendEdgar Alexa73.5d4
adservio/web!2409adservio/webDaniel Onisoru60.3d1920
adservio/helm2!246adservio/helm2Daniel Onisoru13.4d50
adservio/frontend!1830adservio/frontendDaniel Onisoru12.3d6350
adservio/web!2500adservio/webIonut Ciolan10.9d62
adservio/frontend!1839adservio/frontendPetronel Pavel9.9d40
adservio/web!2504adservio/webCatalin Cojan9.1d20
adservio/social!20adservio/socialAlex Murarescu9.1d848
adservio/helm2!251adservio/helm2Alex Murarescu9.1d70
adservio/devops/site-sentry!12adservio/devops/site-sentryDaniel Onisoru8.0d700
adservio/web!2513adservio/webPetronel Pavel4.9d180

Methodology And Limits

  • This report uses visible non-author GitLab comments as the strongest review-start proxy.
  • GitLab approval API coverage is shown separately; missing approval API data should be read as traceability gap, not proof that no approval happened.
  • Review completion uses the first `CR - Approved` label-add event after review starts when GitLab label history provides one; otherwise it falls back to merge time.
  • Last-author-commit metrics use the latest non-merge MR commit authored by the MR author strictly before review starts.
  • Timing metrics in this report exclude Saturday and Sunday hours using the Europe/Bucharest calendar.
  • Review-quality scoring is heuristic: it rewards visible substantive comments, multiple reviewers, and post-review pushes, and it penalizes large MRs with shallow visible discussion.
  • `Active open backlog rate` excludes draft MRs and uses a > 48 working-hour age threshold.
  • Open MR backlog age is a queue-health signal, not proof that every old open MR is actively waiting for review right now.