Adservio Code Review Analysis
A read-only analysis of recent merge request review behavior in GitLab, focused on visible review discussion, reviewer distribution, queue health, MR size, and traceability gaps.
Executive Summary
Bottom line: review throughput is not the main risk here; traceability and queue hygiene are. The team is still merging code, but most merges leave no durable visible review trail and the open queue is overwhelmingly stale.
What Matters
- Traceability is the clearest control gap: 62 of 64 merged MRs (96.9%) showed no visible non-author review comment in GitLab.
- `CR - Approved` is currently too weak as evidence on its own: 28.1% of merged MRs carried that label without any visible review discussion.
- Queue health is poor: 88.1% of active open MRs are already older than 48 working hours. The oldest example is adservio/billing/helm-deletion_scheduled-108!15 at 689.4d open.
- Visible review capacity is thin and concentrated: only 2 visible review touches were detected in the whole window, and the top 3 reviewers handled 100.0% of them.
- adservio/helm2 is the highest-volume review surface with 20 merged MRs and only 0.0% visible review coverage. adservio/web is the next meaningful flow at 18 merges and 0.0% visible review coverage.
- MR size is not the main story: median changed files were 2.0, and only 6.2% of merged MRs were above 20 files. Even the slowest merged example, adservio/web!2632, took 49.0d with 1 changed files, so the dominant problem still looks like review discipline and queue ownership rather than consistently oversized MRs.
Leadership Analysis
- The operating rhythm is serviceable at the median (0.9h created-to-merged), which means the biggest leverage is improving process fidelity rather than pushing for even more raw throughput.
- With 88.1% of active MRs already stale, the open list is functioning more like inventory than prioritization support. adservio/billing/helm-deletion_scheduled-108!15 being open for 689.4d is a strong sign that ownership and review handoffs are not being actively reset.
- Reviewer concentration is now a resilience issue, not just a fairness issue. When the top 3 reviewers carry 100.0% of visible touches, review quality, continuity, and queue health all become sensitive to a very small set of people.
- The spread between a 2.0-file median MR and a 49.0d longest merged cycle (adservio/web!2632, 1 changed files) suggests a few ownership-heavy exceptions are dragging on outside normal flow. Those should be managed as explicit escalations, not left to age inside the common queue.
Recommended Actions
- Make one durable review artifact mandatory before merge: a substantive non-author GitLab review comment, a recorded approval, or both. A label alone should no longer count as sufficient evidence. The approval API coverage is also low, so the fix should include tooling or policy that leaves an auditable trace by default.
- Run a stale-MR reset on anything older than 48 working hours: close abandoned work, re-confirm owner and reviewer on the rest, and turn the open list back into a real queue instead of a parking lot. Start with adservio/billing/helm-deletion_scheduled-108!15 and the rest of the oldest backlog because their age now obscures whether they are still real priorities.
- Put adservio/helm2 under explicit review guardrails for the next cycle. It combines enough volume with weak visible review coverage, which makes it the best place to tighten the process and see impact quickly.
- Broaden the reviewer bench beyond Achim Stefan and the current small reviewer set. The present concentration is a continuity risk and will keep queue health fragile when one person is away.
Improvement Ideas
- Set explicit operating standards for the next quarter: require one auditable peer-review artifact before merge, target first review inside one working day for active MRs, and keep the stale active backlog below 15%. What gets measured this clearly is far more likely to improve.
- Run a four-week process experiment on adservio/helm2: dedicated reviewer-of-the-week coverage, explicit reviewer assignment at MR creation, and a lightweight weekly audit of silent merges. It is the highest-yield place to test whether better ownership changes the data.
- Create a reviewer rotation with named backup coverage for the busiest repos. Good review systems depend on redundancy, not heroics, and rotation is the fastest way to lower reviewer bus factor without slowing delivery.
Supporting Evidence
- 62 of 64 merged MRs (96.9%) had no visible non-author review comment in GitLab.
- 20 of 64 merged MRs (31.2%) carried the `CR - Approved` label.
- 18 merged MRs (28.1%) were labeled `CR - Approved` without any visible non-author review comment.
- 6.2% of merged MRs changed more than 20 files, while 6.2% changed more than 50 files.
- Among MRs with visible review discussion, the median last-author-commit to first-review time was 34.9h.
- The median last-author-commit to `CR - Approved` time was 35.2h.
- The top 3 reviewers accounted for 100.0% of visible review touches.
- 59 of 67 active open MRs (88.1%) were older than 48 working hours.
Merged MRs Merged MRs inside the analysis window. | 64 |
Open MRs All currently open group MRs. | 94 |
Active open MRs Open MRs excluding drafts. | 67 |
Draft open MRs Open MRs marked draft/WIP. | 27 |
Visible review rate Merged MRs with at least one visible non-author GitLab comment. | 3.1% |
Merged without visible review comment Merged MRs with zero visible non-author comments. | 96.9% |
CR - Approved label coverage Merged MRs carrying the CR-approved label. | 31.2% |
Approval API coverage Merged MRs with at least one approver in the GitLab approvals API. | 7.8% |
CR - Approved without visible review comment CR-approved MRs with no visible non-author comment. | 28.1% |
Median MR created -> first review Working time from MR creation to first visible non-author comment. | 34.9h |
Median last author commit -> first review Working time from last author commit before review to first visible non-author comment. | 34.9h |
Median first review -> CR - Approved Working time from first visible comment to CR-approved label after review start, else merge. | 0.3h |
Median MR created -> CR - Approved Working time from MR creation to CR-approved label after review start, else merge. | 35.2h |
Median last author commit -> CR - Approved Working time from last author commit before review to CR-approved label after review start, else merge. | 35.2h |
Median MR created -> merged Working time from MR creation to merge. | 0.9h |
Median changed files Median GitLab `changes_count` value. | 2.0 |
MRs > 5 files Merged MRs where `changes_count` is above 5. | 20.3% |
MRs > 10 files Merged MRs where `changes_count` is above 10. | 9.4% |
MRs > 20 files Merged MRs where `changes_count` is above 20. | 6.2% |
MRs > 50 files Merged MRs where `changes_count` is above 50. | 6.2% |
Top 3 reviewer touch share Share of visible review touches handled by the top 3 reviewers. | 100.0% |
Active open backlog rate Non-draft open MRs older than 48 working hours. | 88.1% |
Timing Breakdown
These headline timing medians bring back the anchor-to-anchor numbers directly, using working time with weekends excluded.
| Median MR created -> first review | 34.9h |
| Median last author commit -> first review | 34.9h |
| Median MR created -> CR - Approved | 35.2h |
| Median first review -> CR - Approved | 0.3h |
| Median last author commit -> CR - Approved | 35.2h |
| Median MR created -> merged | 0.9h |
Reviewer Distribution
| Achim Stefan | 1 | 1 | 50.0% |
| Dragoș Ivan | 1 | 3 | 50.0% |
Repo Breakdown
| adservio/helm2 | 20 | 0.0% | 0.0% | 1.0 |
| adservio/web | 18 | 0.0% | 38.9% | 1.5 |
| adservio/frontend | 11 | 9.1% | 90.9% | 3 |
| adservio/accommodations/backend | 5 | 0.0% | 0.0% | 6 |
| adservio/platform/iac | 4 | 0.0% | 0.0% | 2.5 |
| adservio/uni/backend | 3 | 0.0% | 33.3% | 3 |
| adservio/services/notifications | 1 | 0.0% | 0.0% | 5 |
| adservio/subscriptions/backend | 1 | 0.0% | 100.0% | 5 |
| adservio/timetables-generator | 1 | 100.0% | 100.0% | 4 |
Visible Review Discussion MRs
Compact by default: key CR metrics stay visible, and each row expands inline for the full audit trail. The table starts sorted by Last Commit -> First Review.
| Details | ||||||
|---|---|---|---|---|---|---|
| adservio/frontend!2132 | [ADS-4026] [Abonamente][Admin] - Option to disable packages | 3/5 Solid | 20.4h | 20.4h | 20.4h | |
Repo adservio/frontend Author Edgar Alexa Reviewers Achim Stefan Review Comments 1 Quality Notes 1 visible comment; 1 substantive comment; single reviewer; 2 post-review pushes Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 2 MR Created 2026-09-10 16:55 Last Author Commit 2026-09-10 16:54 First Review 2026-09-11 13:19 CR Approved 2026-09-11 13:21 Merged 2026-09-15 10:06 First Review -> CR Approved 0.0h Last Commit -> CR Approved 20.5h Created -> Merged 2.7d | ||||||
| adservio/timetables-generator!12 | [ADS-8750][ADS-8778][ADS-8647] RabbitMQ startup crash, parseErrors, socket hang up on | 3/5 Solid | 2.1d | 2.1d | 2.1d | |
Repo adservio/timetables-generator Author Ionut Ciolan Reviewers Dragoș Ivan Review Comments 3 Quality Notes 3 visible comments; 1 substantive comment; single reviewer; 2 post-review pushes Substantive Comments 1 Reviewer Count 1 Post-Review Pushes 2 MR Created 2026-09-16 14:05 Last Author Commit 2026-09-16 14:04 First Review 2026-09-18 15:28 CR Approved 2026-09-18 15:59 Merged 2026-09-18 15:59 First Review -> CR Approved 0.5h Last Commit -> CR Approved 2.1d Created -> Merged 2.1d | ||||||
No Visible Review Comment Audit
These merged MRs had no visible non-author GitLab comment under the current heuristic. Use this section to audit whether the gap is a real review-process issue or a GitLab traceability issue.
Total MRs62
With CR Label18
With Approval API5
- Open the MR link and check the Overview tab for
CR - Approvedand any approval widget signal. - Check Activity / Discussions for real human reviewer comments.
- If you only see system notes, merge notes, mentions, or bot activity, it stays in this audit set.
- If you find a genuine reviewer comment from someone other than the author, treat that MR as a false positive of this heuristic.
full audit table (62 MRs). Click again to collapse.
| adservio/helm2!385 | adservio/helm2 | ADS-8732: add platform latency regression-vs-baseline alerts | Rojan Shrestha | 2026-09-14 | ||
| adservio/helm2!391 | adservio/helm2 | ADS-8743: add critical tier for container crash-looping | Rojan Shrestha | 2026-09-14 | ||
| adservio/web!2743 | adservio/web | [ADS-7988] Persist school logo temporary uploads using a stable public URL | Catalin Cojan | 2026-09-14 | Yes | |
| adservio/accommodations/backend!80 | adservio/accommodations/backend | [ADS-8706] 2026/2027 contract | Ionut Ciolan | 2026-09-14 | ||
| adservio/helm2!393 | adservio/helm2 | ADS-8738: apply critical alert dedup to tuiasi and drop the slack-critical receiver | Rojan Shrestha | 2026-09-14 | ||
| adservio/helm2!386 | adservio/helm2 | ADS-8734: fix Traefik p95 histogram gap overstating Billing latency | Rojan Shrestha | 2026-09-14 | ||
| adservio/web!2696 | adservio/web | [S: ADS-7818] SIIIR import students | Marian Andrei | 2026-09-14 | ||
| adservio/services/notifications!22 | adservio/services/notifications | [S: ADS-7818] SIIIR import students | Marian Andrei | 2026-09-14 | ||
| adservio/frontend!2094 | adservio/frontend | [S-7818][ADS-8496] Import SIIIR students | Petronel Pavel | 2026-09-14 | ||
| adservio/helm2!395 | adservio/helm2 | ADS-8782: raise web business-hours replica floor from 12 to 16 | Rojan Shrestha | 2026-09-14 | ||
| adservio/web!2632 | adservio/web | [hotfix-roles] Update previous_values for event body | Catalin Cojan | 2026-09-14 | Yes | |
| adservio/helm2!396 | adservio/helm2 | ADS-8743: match the Job exclusion window to the restart lookback in KubePodContainerCrashLooping | Rojan Shrestha | 2026-09-14 | ||
| adservio/helm2!397 | adservio/helm2 | ADS-8743: drop the warning restart alert, keep the crashloop page | Rojan Shrestha | 2026-09-14 | ||
| adservio/subscriptions/backend!128 | adservio/subscriptions/backend | [ADS-4026] [Abonamente][Admin] - Option to disable packages | Edgar Alexa | 2026-09-15 | Yes | |
| adservio/frontend!2140 | adservio/frontend | [ADS-8693] - added filters for tennantBillingProfile and status on services page | George Murgoci | 2026-09-15 | Yes | |
| adservio/frontend!2137 | adservio/frontend | [ADS-8746] Selectarea automata a profesorului pentru materiile asociate unui singur profesor | Petronel Pavel | 2026-09-15 | Yes | |
| adservio/frontend!2141 | adservio/frontend | [ADS-8783] Permisiune editare din Rol manager a structurii universitare pentru... | Achim Stefan | 2026-09-15 | Yes | |
| adservio/frontend!2136 | adservio/frontend | [ADS-8754] intarziere la selectarea coordonatorului clasei | Petronel Pavel | 2026-09-15 | Yes | |
| adservio/web!2766 | adservio/web | [HOTFIX] Keep SIIIR classes without a study year out of the class confirm | Marian Andrei | 2026-09-15 | ||
| adservio/frontend!2138 | adservio/frontend | [ADS-8575] - BillingProfile ui updates | George Murgoci | 2026-09-15 | Yes | |
| adservio/uni/backend!258 | adservio/uni/backend | commit test | Andrei Alexandru | 2026-09-15 | Yes | |
| adservio/uni/backend!259 | adservio/uni/backend | [ADS-8796]: Situatie Scolara: Adaugare discipline extra | Andrei Alexandru | 2026-09-15 | ||
| adservio/web!2767 | adservio/web | [ADS-8486]: Implement import functionality for school data | Andrei Dragan | 2026-09-15 | Yes | |
| adservio/helm2!399 | adservio/helm2 | ADS-8743: bring back the container restart alert at 5 in 30m as a warning | Rojan Shrestha | 2026-09-16 | ||
| adservio/platform/iac!85 | adservio/platform/iac | ADS-8741: add S3 gateway endpoint to staging private route tables | Rojan Shrestha | 2026-09-16 | ||
| adservio/platform/iac!88 | adservio/platform/iac | ADS-8741: make s3 module versioning optional and support multipart abort | Rojan Shrestha | 2026-09-16 | ||
| adservio/platform/iac!89 | adservio/platform/iac | ADS-8628: keep RDS default MySQL idle timeouts in staging | Rojan Shrestha | 2026-09-16 | ||
| adservio/platform/iac!90 | adservio/platform/iac | ADS-8741: add staging loki and tempo buckets with IRSA roles | Rojan Shrestha | 2026-09-16 | ||
| adservio/helm2!400 | adservio/helm2 | Open the staging private ingress load balancer to all sources | Rojan Shrestha | 2026-09-16 | ||
| adservio/helm2!401 | adservio/helm2 | ADS-8741: add staging loki caches and S3 IRSA annotations | Rojan Shrestha | 2026-09-16 | ||
| adservio/web!2772 | adservio/web | [ADS-8789] Eroare 400 la completare formular contact | Petronel Pavel | 2026-09-16 | ||
| adservio/web!2769 | adservio/web | [ADS-8799] Selectarea altui elev din catalog nu actualizeaza pagina | Petronel Pavel | 2026-09-16 | Yes | |
| adservio/helm2!402 | adservio/helm2 | ADS-8741: add S3 schema period to staging loki | Rojan Shrestha | 2026-09-16 | ||
| adservio/web!2771 | adservio/web | [HOTFIX] Uni events payload changes | Ionut Ciolan | 2026-09-16 | Yes | Yes |
| adservio/helm2!403 | adservio/helm2 | ADS-8741: enable loki retention on staging | Rojan Shrestha | 2026-09-16 | Yes | |
| adservio/helm2!404 | adservio/helm2 | ADS-8741: move staging tempo trace storage to S3 | Rojan Shrestha | 2026-09-16 | ||
| adservio/helm2!405 | adservio/helm2 | ADS-8814: move production warnings to alerts-prod-warning, stop PagerDuty auto-resolve, title-case the cluster name | Rojan Shrestha | 2026-09-17 | ||
| adservio/web!2770 | adservio/web | [ADS-8797] Image Cropper | Petronel Pavel | 2026-09-17 | Yes | |
| adservio/frontend!2144 | adservio/frontend | [ADS-8797] Image Cropper | Petronel Pavel | 2026-09-17 | Yes | |
| adservio/accommodations/backend!82 | adservio/accommodations/backend | [Hotfix] uni events | Ionut Ciolan | 2026-09-17 | Yes | |
| adservio/helm2!406 | adservio/helm2 | ADS-8814: re-seal the production slack webhook so the secret can decrypt again | Rojan Shrestha | 2026-09-17 | ||
| adservio/web!2775 | adservio/web | [HOTFIX] Add cleanup for students duplicated by the SIIIR import | Marian Andrei | 2026-09-17 | ||
| adservio/web!2777 | adservio/web | [HOTFIX] Uni events - tenant id fixed | Ionut Ciolan | 2026-09-17 | ||
| adservio/helm2!407 | adservio/helm2 | Scale library-api on cpu only and drop the memory trigger | Rojan Shrestha | 2026-09-17 | ||
| adservio/frontend!2147 | adservio/frontend | Improve translation skill | Achim Stefan | 2026-09-17 | Yes | |
| adservio/web!2773 | adservio/web | [ADS-8724] Modal detalii elev ani trecuți | Petronel Pavel | 2026-09-17 | Yes | |
| adservio/frontend!2145 | adservio/frontend | [ADS-8724] Modal detalii elev ani trecuți | Petronel Pavel | 2026-09-17 | Yes | |
| adservio/web!2779 | adservio/web | [HOTFIX] uni events - group id fixed | Ionut Ciolan | 2026-09-17 | ||
| adservio/helm2!410 | adservio/helm2 | Turn off the deployment latency regression alerts in production | Rojan Shrestha | 2026-09-17 | ||
| adservio/helm2!409 | adservio/helm2 | ADS-8838: require 5xx to still be arriving before TraefikServiceHighErrorRate fires | Rojan Shrestha | 2026-09-17 | ||
| adservio/web!2780 | adservio/web | [ADS-8807] Hotfix siiir elevi | Marian Andrei | 2026-09-17 | ||
| adservio/accommodations/backend!84 | adservio/accommodations/backend | [ADS-8803] new tenant | Ionut Ciolan | 2026-09-18 | ||
| adservio/accommodations/backend!85 | adservio/accommodations/backend | [ADS-8803] removed default ALTE faculty for new students from sync students command | Ionut Ciolan | 2026-09-18 | ||
| adservio/helm2!412 | adservio/helm2 | ADS-8838: widen the sustained-error probe on TraefikServiceHighErrorRate to 2m | Rojan Shrestha | 2026-09-18 | ||
| adservio/accommodations/backend!86 | adservio/accommodations/backend | [HOTFIX] accommodation events - restart on FD error | Ionut Ciolan | 2026-09-18 | ||
| adservio/web!2774 | adservio/web | [hotfix-laravel-otel] Add missign configuration variables | Catalin Cojan | 2026-09-18 | ||
| adservio/helm2!413 | adservio/helm2 | ADS-8852: slim Slack alerts to summary plus identity, fix decimal counts, re-enable latency regression at 20 percent | Rojan Shrestha | 2026-09-18 | ||
| adservio/web!2782 | adservio/web | SIIIR improvments & bugs | Marian Andrei | 2026-09-18 | ||
| adservio/frontend!2150 | adservio/frontend | [ADS-8678]Posibilitatea de a edita grupa studentului ulterior înrolării (când... | Achim Stefan | 2026-09-18 | Yes | |
| adservio/uni/backend!260 | adservio/uni/backend | [ADS-8678] Asociere grupa | Andrei Alexandru | 2026-09-18 | Yes | |
| adservio/web!2783 | adservio/web | HOTFIX: Delete duplicate parents imported via SIIIR | Marian Andrei | 2026-09-18 | ||
| adservio/web!2776 | adservio/web | [ADS-8624] Return actionable 2FA password errors | Valentin Pal | 2026-09-18 | Yes |
Oldest Active Open MRs (> 48 Working Hours)
| adservio/billing/helm-deletion_scheduled-108!15 | adservio/billing/helm-deletion_scheduled-108 | Robert | 689.4d | 0 | |
| adservio/subscriptions/helm-deletion_scheduled-125!4 | adservio/subscriptions/helm-deletion_scheduled-125 | Daniel Onisoru | 627.4d | 0 | |
| adservio/web!2091 | adservio/web | Andrei Dragan | 316.6d | 5 | |
| adservio/helm2!137 | adservio/helm2 | Raul Popovici | 292.6d | 0 | |
| adservio/videothumb!5 | adservio/videothumb | Raul Popovici | 289.6d | 0 | |
| adservio/timetables-generator!9 | adservio/timetables-generator | Raul Popovici | 289.6d | 0 | |
| adservio/web!2344 | adservio/web | George Murgoci | 180.4d | 0 | |
| adservio/library!26 | adservio/library | Raul Popovici | 160.5d | 0 | |
| adservio/subscriptions/backend!103 | adservio/subscriptions/backend | Edgar Alexa | 158.5d | 4 | |
| adservio/admission/backend!104 | adservio/admission/backend | Edgar Alexa | 158.4d | 0 |
Longest Merged Cycles
| adservio/web!2632 | adservio/web | Catalin Cojan | 49.0d | 1 | 0 |
| adservio/web!2696 | adservio/web | Marian Andrei | 20.7d | 54 | 0 |
| adservio/frontend!2094 | adservio/frontend | Petronel Pavel | 13.0d | 79 | 0 |
| adservio/web!2743 | adservio/web | Catalin Cojan | 5.0d | 3 | 0 |
| adservio/accommodations/backend!80 | adservio/accommodations/backend | Ionut Ciolan | 3.9d | 72 | 0 |
| adservio/services/notifications!22 | adservio/services/notifications | Marian Andrei | 3.0d | 5 | 0 |
| adservio/frontend!2132 | adservio/frontend | Edgar Alexa | 2.7d | 10 | 1 |
| adservio/helm2!386 | adservio/helm2 | Rojan Shrestha | 2.2d | 2 | 0 |
| adservio/timetables-generator!12 | adservio/timetables-generator | Ionut Ciolan | 2.1d | 4 | 3 |
| adservio/helm2!385 | adservio/helm2 | Rojan Shrestha | 2.0d | 3 | 0 |
Methodology And Limits
- This report uses visible non-author GitLab comments as the strongest review-start proxy.
- GitLab approval API coverage is shown separately; missing approval API data should be read as traceability gap, not proof that no approval happened.
- Review completion uses the first `CR - Approved` label-add event after review starts when GitLab label history provides one; otherwise it falls back to merge time.
- Last-author-commit metrics use the latest non-merge MR commit authored by the MR author strictly before review starts.
- Timing metrics in this report exclude Saturday and Sunday hours using the Europe/Bucharest calendar.
- Review-quality scoring is heuristic: it rewards visible substantive comments, multiple reviewers, and post-review pushes, and it penalizes large MRs with shallow visible discussion.
- `Active open backlog rate` excludes draft MRs and uses a > 48 working-hour age threshold.
- Open MR backlog age is a queue-health signal, not proof that every old open MR is actively waiting for review right now.