GitLab-backed analysis

Adservio Code Review Analysis

A read-only analysis of recent merge request review behavior in GitLab, focused on visible review discussion, reviewer distribution, queue health, MR size, and traceability gaps.

Period: 2026-09-26 07:00 to 2026-10-03 07:00
Primary source: GitLab merge request metadata, notes, labels, commits, and approvals endpoints.

Bottom line: review throughput is not the main risk here; traceability and queue hygiene are. The team is still merging code, but most merges leave no durable visible review trail and the open queue is overwhelmingly stale.

What Matters

  • Traceability is the clearest control gap: 68 of 74 merged MRs (91.9%) showed no visible non-author review comment in GitLab.
  • `CR - Approved` is currently too weak as evidence on its own: 27.0% of merged MRs carried that label without any visible review discussion.
  • Queue health is poor: 88.1% of active open MRs are already older than 48 working hours. The oldest example is adservio/billing/helm-deletion_scheduled-108!15 at 689.3d open.
  • Visible review capacity is thin and concentrated: only 6 visible review touches were detected in the whole window, and the top 3 reviewers handled 100.0% of them.
  • adservio/web is the highest-volume review surface with 20 merged MRs and only 10.0% visible review coverage. adservio/frontend is the next meaningful flow at 18 merges and 5.6% visible review coverage.
  • MR size is not the main story: median changed files were 3.0, and only 8.1% of merged MRs were above 20 files. Even the slowest merged example, adservio/web!2697, took 34.1d with 1 changed files, so the dominant problem still looks like review discipline and queue ownership rather than consistently oversized MRs.

Leadership Analysis

  • This does not read like a slow-review system. The median last-author-commit to first-review time was 1.8h, so the dominant weakness is decision recording and merge discipline, not reviewer reaction speed.
  • With 88.1% of active MRs already stale, the open list is functioning more like inventory than prioritization support. adservio/billing/helm-deletion_scheduled-108!15 being open for 689.3d is a strong sign that ownership and review handoffs are not being actively reset.
  • Reviewer concentration is now a resilience issue, not just a fairness issue. When the top 3 reviewers carry 100.0% of visible touches, review quality, continuity, and queue health all become sensitive to a very small set of people.
  • The spread between a 3.0-file median MR and a 34.1d longest merged cycle (adservio/web!2697, 1 changed files) suggests a few ownership-heavy exceptions are dragging on outside normal flow. Those should be managed as explicit escalations, not left to age inside the common queue.

Recommended Actions

  • Make one durable review artifact mandatory before merge: a substantive non-author GitLab review comment, a recorded approval, or both. A label alone should no longer count as sufficient evidence. The approval API coverage is also low, so the fix should include tooling or policy that leaves an auditable trace by default.
  • Run a stale-MR reset on anything older than 48 working hours: close abandoned work, re-confirm owner and reviewer on the rest, and turn the open list back into a real queue instead of a parking lot. Start with adservio/billing/helm-deletion_scheduled-108!15 and the rest of the oldest backlog because their age now obscures whether they are still real priorities.
  • Put adservio/billing/backend under explicit review guardrails for the next cycle. It combines enough volume with weak visible review coverage, which makes it the best place to tighten the process and see impact quickly.
  • Broaden the reviewer bench beyond Dragoș Ivan and the current small reviewer set. The present concentration is a continuity risk and will keep queue health fragile when one person is away.

Improvement Ideas

  • Set explicit operating standards for the next quarter: require one auditable peer-review artifact before merge, target first review inside one working day for active MRs, and keep the stale active backlog below 15%. What gets measured this clearly is far more likely to improve.
  • Run a four-week process experiment on adservio/billing/backend: dedicated reviewer-of-the-week coverage, explicit reviewer assignment at MR creation, and a lightweight weekly audit of silent merges. It is the highest-yield place to test whether better ownership changes the data.
  • Create a reviewer rotation with named backup coverage for the busiest repos. Good review systems depend on redundancy, not heroics, and rotation is the fastest way to lower reviewer bus factor without slowing delivery.

Supporting Evidence

  • 68 of 74 merged MRs (91.9%) had no visible non-author review comment in GitLab.
  • 23 of 74 merged MRs (31.1%) carried the `CR - Approved` label.
  • 20 merged MRs (27.0%) were labeled `CR - Approved` without any visible non-author review comment.
  • 8.1% of merged MRs changed more than 20 files, while 1.4% changed more than 50 files.
  • Among MRs with visible review discussion, the median last-author-commit to first-review time was 1.8h.
  • The median last-author-commit to `CR - Approved` time was 21.1h.
  • The top 3 reviewers accounted for 100.0% of visible review touches.
  • 59 of 67 active open MRs (88.1%) were older than 48 working hours.
Merged MRs
Merged MRs inside the analysis window.
74
Open MRs
All currently open group MRs.
94
Active open MRs
Open MRs excluding drafts.
67
Draft open MRs
Open MRs marked draft/WIP.
27
Visible review rate
Merged MRs with at least one visible non-author GitLab comment.
8.1%
Merged without visible review comment
Merged MRs with zero visible non-author comments.
91.9%
CR - Approved label coverage
Merged MRs carrying the CR-approved label.
31.1%
Approval API coverage
Merged MRs with at least one approver in the GitLab approvals API.
10.8%
CR - Approved without visible review comment
CR-approved MRs with no visible non-author comment.
27.0%
Median MR created -> first review
Working time from MR creation to first visible non-author comment.
20.3h
Median last author commit -> first review
Working time from last author commit before review to first visible non-author comment.
1.8h
Median first review -> CR - Approved
Working time from first visible comment to CR-approved label after review start, else merge.
21.7h
Median MR created -> CR - Approved
Working time from MR creation to CR-approved label after review start, else merge.
3.4d
Median last author commit -> CR - Approved
Working time from last author commit before review to CR-approved label after review start, else merge.
21.1h
Median MR created -> merged
Working time from MR creation to merge.
3.5h
Median changed files
Median GitLab `changes_count` value.
3.0
MRs > 5 files
Merged MRs where `changes_count` is above 5.
36.5%
MRs > 10 files
Merged MRs where `changes_count` is above 10.
21.6%
MRs > 20 files
Merged MRs where `changes_count` is above 20.
8.1%
MRs > 50 files
Merged MRs where `changes_count` is above 50.
1.4%
Top 3 reviewer touch share
Share of visible review touches handled by the top 3 reviewers.
100.0%
Active open backlog rate
Non-draft open MRs older than 48 working hours.
88.1%

These headline timing medians bring back the anchor-to-anchor numbers directly, using working time with weekends excluded.

Median MR created -> first review20.3h
Median last author commit -> first review1.8h
Median MR created -> CR - Approved3.4d
Median first review -> CR - Approved21.7h
Median last author commit -> CR - Approved21.1h
Median MR created -> merged3.5h
Dragoș Ivan4966.7%
Catalin Cojan1216.7%
Andrei Dragan1116.7%
adservio/web2010.0%20.0%2.0
adservio/frontend185.6%66.7%6.0
adservio/helm2137.7%7.7%3
adservio/billing/backend30.0%33.3%3
adservio/services/notifications333.3%33.3%9
adservio/uni/backend30.0%33.3%7
adservio/accommodations/backend250.0%50.0%15.5
adservio/ai20.0%0.0%2.0
adservio/platform/iac20.0%0.0%3.0
adservio/services/public-schools20.0%50.0%79.5
adservio/subscriptions/backend20.0%50.0%1.0
adservio/websocket20.0%0.0%10.0

Visible Review Discussion MRs

Compact by default: key CR metrics stay visible, and each row expands inline for the full audit trail. The table starts sorted by Last Commit -> First Review.

Details
adservio/services/notifications!26[ADS-9002] Move group chat realtime to websocket22/5 Light0.9h0.9h20.6h
adservio/accommodations/backend!91[ADS-8682] Accommodations Open-telemetry3/5 Solid4.9d1.5h5.9d
adservio/web!2746[ADS-8715] Refactor download_album cron into a core-events job3/5 Solid1.7h1.8h15.0d
adservio/helm2!432[ADS-9002] Move group chat realtime to websocket21/5 Very light20.1h20.1h20.1h
adservio/frontend!2171[ADS-9002] Move group chat realtime to websocket22/5 Light20.5h20.6h21.1h
adservio/web!2697[ADS-8506] Fix parent birth date export2/5 Light12.1dn/a34.1d

No Visible Review Comment Audit

These merged MRs had no visible non-author GitLab comment under the current heuristic. Use this section to audit whether the gap is a real review-process issue or a GitLab traceability issue.

Total MRs68
With CR Label20
With Approval API8
  • Open the MR link and check the Overview tab for CR - Approved and any approval widget signal.
  • Check Activity / Discussions for real human reviewer comments.
  • If you only see system notes, merge notes, mentions, or bot activity, it stays in this audit set.
  • If you find a genuine reviewer comment from someone other than the author, treat that MR as a false positive of this heuristic.
full audit table (68 MRs). Click again to collapse.
adservio/services/notifications!25adservio/services/notifications[ADS-8959]: Dedupe notifications using RedisDragoș Ivan2026-09-27
adservio/web!2803adservio/web[ADS-8959]: Dedupe notifications using RedisDragoș Ivan2026-09-27
adservio/helm2!431adservio/helm2[ADS-8959]: Rate Limits for NotificationsDragoș Ivan2026-09-27
adservio/frontend!2169adservio/frontend[Acommodations] Fix repartition faculties selector for unique study valuesAchim Stefan2026-09-28Yes
adservio/web!2798adservio/web[ADS-8889] Ora afisata incorect in istoricul noteiPetronel Pavel2026-09-28
adservio/web!2809adservio/web[ADS-8919][ADS-8933] Invalidate user token + register parent nameIonut Ciolan2026-09-28
adservio/billing/backend!292adservio/billing/backend[ADS-9865] - made invoice name/description varchar to 512George Murgoci2026-09-28
adservio/services/public-schools!95adservio/services/public-schools[ADS-8998] Update linkuri site publicPetronel Pavel2026-09-28
adservio/services/public-schools!94adservio/services/public-schools[ADS-4294] Actualizare pagina Edumarket & CSRPetronel Pavel2026-09-28Yes
adservio/helm2!434adservio/helm2ADS-8939: promote KubePodCrashLooping and KubeDeploymentReplicasMismatch to critical on prod and TUIASIRojan Shrestha2026-09-28
adservio/helm2!433adservio/helm2ADS-9004: raise the TUIASI warning latency threshold for uni-api while ADS-8912 is openRojan Shrestha2026-09-28
adservio/frontend!2173adservio/frontendshow table menu , hide change status/change score on ended sessionsGeorge Murgoci2026-09-28
adservio/accommodations/backend!90adservio/accommodations/backend[ADS-8888][ADS-8893] Students balances - accommodation status filter, recalculate student soldIonut Ciolan2026-09-28
adservio/web!2781adservio/web[ADS-8723] Timetable generator - co-teacher activitiesIonut Ciolan2026-09-28
adservio/frontend!2170adservio/frontend[ADS-8888] Eroare la export fisierAchim Stefan2026-09-28Yes
adservio/frontend!2174adservio/frontend[ADS-8936] Used setup mode for 0 amount sessionsEdgar Alexa2026-09-28Yes
adservio/subscriptions/backend!133adservio/subscriptions/backend[ADS-8936] Used setup mode for 0 amount sessionsEdgar Alexa2026-09-28Yes
adservio/billing/backend!291adservio/billing/backend[ADS-8936] Used setup mode for 0 amount sessionsEdgar Alexa2026-09-28Yes
adservio/frontend!2172adservio/frontend[ADS-8954] Register - Actualizare textePetronel Pavel2026-09-28Yes
adservio/platform/iac!95adservio/platform/iacADS-9018: set table_definition_cache per catalog shard from measured table countsRojan Shrestha2026-09-29
adservio/helm2!435adservio/helm2[HOTFIX] accommodations tagIonut Ciolan2026-09-29
adservio/web!2811adservio/web[ADS-9002] Move group chat realtime to websocket2Daniel Onisoru2026-09-29Yes
adservio/websocket!6adservio/websocket[ADS-9002] Move group chat realtime to websocket2Daniel Onisoru2026-09-29
adservio/helm2!383adservio/helm2[ADS-8715] Remove the download-album cronDaniel Onisoru2026-09-29
adservio/web!2814adservio/web[HOTFIX] copy classes data removed dropIonut Ciolan2026-09-29
adservio/helm2!436adservio/helm2[ADS-9026] Rename websocket2 / ws2 to websocketDaniel Onisoru2026-09-29
adservio/frontend!2176adservio/frontend[ADS-9026] Rename websocket2 / ws2 to websocketDaniel Onisoru2026-09-29
adservio/web!2813adservio/web[ADS-9026] Rename websocket2 / ws2 to websocketDaniel Onisoru2026-09-29
adservio/websocket!7adservio/websocket[ADS-9026] Rename websocket2 / ws2 to websocketDaniel Onisoru2026-09-29
adservio/billing/backend!293adservio/billing/backend[package-availability-fix] Billing failing testEdgar Alexa2026-09-29
adservio/frontend!2177adservio/frontend[package-availability-fix] Checked selected package for buy button visibilityEdgar Alexa2026-09-29
adservio/frontend!2178adservio/frontend[selected-packages-mitigation] hard redirect for old packageEdgar Alexa2026-09-29
adservio/web!2812adservio/web[ADS-9017]: Fix parameter structure in getWhere method callAndrei Dragan2026-09-29Yes
adservio/frontend!2175adservio/frontend[ADS-9017] Marcare elev cu CESPetronel Pavel2026-09-29YesYes
adservio/web!2815adservio/web[HOTFIX] copy classes - skip create student if existsIonut Ciolan2026-09-29
adservio/helm2!437adservio/helm2Make deploy_env manual for MRs labelled NO ENVIRONMENTDaniel Onisoru2026-09-29
adservio/services/notifications!27adservio/services/notificationsForward MR labels to the helm2 pipeline as CI_LABELSDaniel Onisoru2026-09-29
adservio/uni/backend!264adservio/uni/backendForward MR labels to the helm2 pipeline as CI_LABELSDaniel Onisoru2026-09-29
adservio/docgen2/backend!176adservio/docgen2/backendForward MR labels to the helm2 pipeline as CI_LABELSDaniel Onisoru2026-09-29
adservio/web!2817adservio/web[ADS-8895] Validate SSO id_token audience and cache provider JWKS in RedisDaniel Onisoru2026-09-29
adservio/web!2816adservio/web[ADS-9030] Remove "Echipa Adservio" as a recipient across the appDaniel Onisoru2026-09-29
adservio/frontend!2179adservio/frontend[ADS-9030] Remove "Echipa Adservio" as a recipient across the appDaniel Onisoru2026-09-29Yes
adservio/uni/backend!265adservio/uni/backend[ADS-8912] Optimize student searchAndrei Alexandru2026-09-29
adservio/helm2!428adservio/helm2ADS-8648: page on FET and RabbitMQ outages and stop resolved alerts rendering as firingRojan Shrestha2026-09-30
adservio/platform/iac!92adservio/platform/iacADS-8874: make the RDS alarms able to detect a fast disk fill and an instance that stops reportingRojan Shrestha2026-09-30
adservio/frontend!2180adservio/frontend[invalid-package-redirect] redirect to /buy if package is invalidEdgar Alexa2026-09-30
adservio/frontend!2182adservio/frontend[ADS-8912] POST /api/v2/uni/students/search takes 2.0s at the median and is...Achim Stefan2026-09-30YesYes
adservio/frontend!2167adservio/frontend[ADS-8599] Ajustari echivalari noteAchim Stefan2026-09-30YesYes
adservio/uni/backend!261adservio/uni/backend[ADS-8599] Situatie Scolara - EchivalareAndrei Alexandru2026-09-30YesYes
adservio/web!2822adservio/webHotfix copy classes dataIonut Ciolan2026-09-30
adservio/frontend!2183adservio/frontend[ADS-9050] Limitare trimite cod înregistrarePetronel Pavel2026-09-30Yes
adservio/subscriptions/backend!136adservio/subscriptions/backend[ADS-8936] Added guard for empty user personal and org subs fallbackEdgar Alexa2026-09-30
adservio/web!2825adservio/webHotfix copy classes dataIonut Ciolan2026-10-01
adservio/web!2810adservio/web[ADS-7421] [BE] Cleanup NoutatiCatalin Cojan2026-10-01YesYes
adservio/frontend!2181adservio/frontend[ADS-7421] [FE] Cleanup NoutatiCatalin Cojan2026-10-01Yes
adservio/web!2827adservio/webHotfix copy classes dataIonut Ciolan2026-10-01
adservio/web!2821adservio/web[ADS-8975]: See only active students in access codes for classIoana Ivan2026-10-01Yes
adservio/web!2820adservio/web[ADS-9038] Conduita timestampPetronel Pavel2026-10-01
adservio/web!2819adservio/web[ADS-7578] add sentinel retry and database fallbacks during redis outagesCatalin Cojan2026-10-01YesYes
adservio/ai!86adservio/aisummaries table indexAlex Murarescu2026-10-01
adservio/helm2!440adservio/helm2ADS-9070: restore latencyWarningOverrides so helm-core renders againRojan Shrestha2026-10-02
adservio/helm2!439adservio/helm2ADS-9040: add MySQL table cache churn dashboard to GrafanaRojan Shrestha2026-10-02
adservio/helm2!424adservio/helm2[ADS-8682] Accommodations open-telemetryIonut Ciolan2026-10-02
adservio/frontend!2190adservio/frontendAccommodations fixAchim Stefan2026-10-02YesYes
adservio/ai!88adservio/aifix notifsAlex Murarescu2026-10-02
adservio/helm2!441adservio/helm2ADS-9085: restore mcp-api to 1 replica in productionRojan Shrestha2026-10-02
adservio/frontend!2189adservio/frontend[ADS-9069] Confirm photo deletion, show the success toaster and mark delete as destructiveDaniel Onisoru2026-10-02Yes
adservio/services/mcp!10adservio/services/mcpfix behavior errorsAlex Murarescu2026-10-02

Oldest Active Open MRs (> 48 Working Hours)

adservio/billing/helm-deletion_scheduled-108!15adservio/billing/helm-deletion_scheduled-108Robert689.3d0
adservio/subscriptions/helm-deletion_scheduled-125!4adservio/subscriptions/helm-deletion_scheduled-125Daniel Onisoru627.4d0
adservio/web!2091adservio/webAndrei Dragan316.6d5
adservio/helm2!137adservio/helm2Raul Popovici292.6d0
adservio/videothumb!5adservio/videothumbRaul Popovici289.6d0
adservio/timetables-generator!9adservio/timetables-generatorRaul Popovici289.6d0
adservio/web!2344adservio/webGeorge Murgoci180.4d0
adservio/library!26adservio/libraryRaul Popovici160.5d0
adservio/subscriptions/backend!103adservio/subscriptions/backendEdgar Alexa158.5d4
adservio/admission/backend!104adservio/admission/backendEdgar Alexa158.4d0
adservio/web!2697adservio/webValentin Pal34.1d11
adservio/web!2746adservio/webDaniel Onisoru15.0d72
adservio/helm2!383adservio/helm2Daniel Onisoru15.0d40
adservio/accommodations/backend!91adservio/accommodations/backendIonut Ciolan7.0d172
adservio/helm2!424adservio/helm2Ionut Ciolan6.9d60
adservio/platform/iac!92adservio/platform/iacRojan Shrestha6.7d50
adservio/ai!86adservio/aiAlex Murarescu6.2d30
adservio/web!2781adservio/webIonut Ciolan6.1d10
adservio/uni/backend!261adservio/uni/backendAndrei Alexandru5.9d70
adservio/services/public-schools!94adservio/services/public-schoolsPetronel Pavel5.1d1580

Methodology And Limits

  • This report uses visible non-author GitLab comments as the strongest review-start proxy.
  • GitLab approval API coverage is shown separately; missing approval API data should be read as traceability gap, not proof that no approval happened.
  • Review completion uses the first `CR - Approved` label-add event after review starts when GitLab label history provides one; otherwise it falls back to merge time.
  • Last-author-commit metrics use the latest non-merge MR commit authored by the MR author strictly before review starts.
  • Timing metrics in this report exclude Saturday and Sunday hours using the Europe/Bucharest calendar.
  • Review-quality scoring is heuristic: it rewards visible substantive comments, multiple reviewers, and post-review pushes, and it penalizes large MRs with shallow visible discussion.
  • `Active open backlog rate` excludes draft MRs and uses a > 48 working-hour age threshold.
  • Open MR backlog age is a queue-health signal, not proof that every old open MR is actively waiting for review right now.